Lock sideffect message

[mernst]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b59dc1c6-a300-4a77-8ab3-2d920a7b4c64

📥 Commits

Reviewing files that changed from the base of the PR and between c10d86a and d2e2542.

📒 Files selected for processing (9)

• annotation-file-utilities/build.gradle
• build.gradle
• checker/build.gradle
• checker/src/main/java/org/checkerframework/checker/lock/LockVisitor.java
• checker/src/main/java/org/checkerframework/checker/lock/messages.properties
• dataflow/build.gradle
• framework/build.gradle
• gradle-mvn-push.gradle
• release.gradle

---

📝 Walkthrough

Walkthrough

LockVisitor.reportFailure() is extended with two new SideEffectAnnotation parameters (seaOfOverriderMethod, seaOfOverriddenMethod), which are now passed into checker.reportError() for the branch handling null lock lists. checkOverride() is updated to supply these values at the call site. The override.sideeffect error message in messages.properties is reworded to state that the overrider annotation is weaker than the overridden annotation. All other changes across multiple Gradle build files (build.gradle, checker/build.gradle, dataflow/build.gradle, framework/build.gradle, annotation-file-utilities/build.gradle, gradle-mvn-push.gradle, release.gradle) are whitespace/formatting-only reformats with no functional changes.

Possibly related PRs

• typetools/checker-framework#7331: Touches root build.gradle Shadow plugin application logic in the same subproject-selection condition reformatted in this PR.
• typetools/checker-framework#7332: Modifies annotation-file-utilities/build.gradle Gradle DSL in the same area as the updateUserOptions dependsOn reformat in this PR.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Updates the Lock Checker’s override side-effect diagnostics to report which side-effect annotations are involved when an overriding method is weaker than the overridden method.

Changes:

• Reworks override.sideeffect message text to include both the overrider and overridden side-effect annotations.
• Updates LockVisitor.reportFailure/checkOverride to pass the additional formatting arguments required by the new message.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
checker/src/main/java/org/checkerframework/checker/lock/messages.properties	Updates override.sideeffect message format and placeholders.
checker/src/main/java/org/checkerframework/checker/lock/LockVisitor.java	Passes side-effect annotation details into the override failure report.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.