Skip to content

Return false, not null#7799

Open
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:type-inf-review-contains-inference-variable
Open

Return false, not null#7799
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:type-inf-review-contains-inference-variable

Conversation

@mernst

@mernst mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 10efe8ad-a9de-49e7-9943-0be140dc6830

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc3a3a and 81a71e2.

📒 Files selected for processing (1)
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/ContainsInferenceVariable.java

📝 Walkthrough

Walkthrough

This change modifies the visitError method in the ContainsInferenceVariable.Visitor class to return false instead of null when visiting an ErrorType. This adjusts the boolean semantics of the type visitor's handling of error types within the inference-variable detection logic.

Changes

File Change Summary
ContainsInferenceVariable.java visitError now returns false instead of null

Sequence Diagram(s)

Not applicable for this change.

Estimated code review effort: 1 (Trivial)

Related issues: None specified.

Related PRs: None specified.

Suggested labels: bug-fix, low-risk

Suggested reviewers: None specified.


A tiny fix, a single line,
Where null once lurked, now false will shine.
No more silent crash to fear,
The visitor's logic now stands clear.
A rabbit hops with quiet cheer. 🐇

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst

mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants