-
Notifications
You must be signed in to change notification settings - Fork 18
Add Gls
and Glspl
for capitalized terms
#121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gls
and Glspl
for capitalized terms
#121
Conversation
Hello @killercup, I think this is a good start. If you are willing to improve on this PR, I'll be glad to help you along with it. Otherwise I'll use your commit as a starting point for the feature. I will leave a review |
Thanks! I'd love to help out but I'm not sure how much time I have to work on this, I mainly just needed this right now and now need to continue writing. If you want to work on this right now, don't stop :) Otherwise I can maybe pick it up over the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is good overall.
I would like to add a shortcut in the future for capitalization like it was done for plural forms. This can be done later on.
That's alright, I can focus on other things and leave this to you if you're willing. If not, I'll pick it up at some point. |
Thanks for the feedback! Had some time and I think I managed to apply all of it.
|
8849751
to
4a88f76
Compare
Thank you, I will take a look! It might take a while, but don't worry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I love what you've done. It works out pretty well. Just a few nitpicks. I see you were unsure about your solution for __get_entry. I think what I suggest in my comments is better overall. Feel free to take it as it is, or make changes.
I believe only a final review should be necessary to merge this @killercup!
@killercup thanks, I'll take over. I merged into a feature branch. |
Oh sorry! Didn't have time to look into this, glad you're taking charge :) |
Very simple implementation, just always uppercases the first letter.
Fixes #48