Skip to content

fix: apply capitalization hook to direct references - #201

Closed
amandeavor wants to merge 1 commit into
typst-community:masterfrom
amandeavor:fix/global-capitalization-hook
Closed

fix: apply capitalization hook to direct references#201
amandeavor wants to merge 1 commit into
typst-community:masterfrom
amandeavor:fix/global-capitalization-hook

Conversation

@amandeavor

Copy link
Copy Markdown

Summary

  • make the capitalization hook configured on make-glossary available to direct gls/Gls calls, not only @ references
  • preserve explicit per-call user-capitalize overrides
  • document the shared behavior and add a multi-word regression case

The configured function is stored in document state and resolved at each reference location. Passing the function through an updater closure avoids Typst treating it as the state update callback itself.

Validation

  • Tytanic 0.2.2: 43/43 tests passed
  • advanced documentation compiled with Typst 0.13.1
  • typstyle check passed for changed Typst sources

Addresses #197.

Copilot AI lite review requested due to automatic review settings August 28, 2026 12:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@quachpas

quachpas commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

I'm sorry to say that I do not accept AI-assisted contributions. See my response in #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants