fix(release): bump dist/PKGBUILD-git pkgver alongside other packaging - #51
Merged
Conversation
`publish-aur.sh::generate_srcinfo` runs makepkg in a container that doesn't fetch the git source, so the `pkgver()` function on PKGBUILD-git is never executed at SRCINFO time. AUR's web display then falls back to the static `pkgver=` field, which has been stuck at 0.1.0 since pre-0.1.1 — visible drift between `facelock-git` and the other AUR packages. Fix the current stale value (0.1.0 → 0.1.3) and extend the `just release` recipe to also bump dist/PKGBUILD-git going forward, matching what it already does for dist/PKGBUILD and dist/PKGBUILD-bin. Runtime behavior is unchanged — `paru -S facelock-git` still computes the real version via `pkgver()` locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs the static pkgver= in dist/PKGBUILD-git with the current release (0.1.3) and extends just release to keep this file in sync on future bumps, preventing the AUR facelock-git page from displaying a stale version (the runtime pkgver() is bypassed during containerized .SRCINFO generation).
Changes:
- Bump static
pkgverindist/PKGBUILD-gitfrom0.1.0to0.1.3. - Add a
sedbump fordist/PKGBUILD-gitin thejust releaserecipe, mirroring the existing PKGBUILD/PKGBUILD-bin handling.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dist/PKGBUILD-git |
Aligns static pkgver with current release version. |
justfile |
Adds dist/PKGBUILD-git to the release-bump sed sequence with an explanatory comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
facelock-gitpage showspkgver=0.1.0even though the runtimepkgver()resolves to the current commit's version.publish-aur.sh::generate_srcinforunsmakepkg --printsrcinfoin a container that doesn't fetch the git source, so thepkgver()function never runs at SRCINFO generation time — AUR's metadata falls back to the staticpkgver=line.0.1.0→0.1.3) so the AUR display is in sync withfacelockandfacelock-binfor the current release.just releaserecipe to also sed-bumpdist/PKGBUILD-git, matching what it already does fordist/PKGBUILDanddist/PKGBUILD-bin, so future releases don't re-drift.Runtime install behavior is unchanged —
paru -S facelock-gitstill computes the real version viapkgver()against the user's local clone.Test plan
just release X.Y.Znow bumpsdist/PKGBUILD-git's staticpkgver=(visual sed inspection)facelock,facelock-bin, andfacelock-giton AUR🤖 Generated with Claude Code