New dependency versions to support uPortal's Bootstrap & jQuery updates#303
Open
Naenyn wants to merge 13 commits intouPortal-Project:masterfrom
Open
New dependency versions to support uPortal's Bootstrap & jQuery updates#303Naenyn wants to merge 13 commits intouPortal-Project:masterfrom
Naenyn wants to merge 13 commits intouPortal-Project:masterfrom
Conversation
Bootstrap 5.0.2 Bootstrap 5.3.8 Fluid Infusion 4.8.0 jQuery 3.0.0 jQuery 3.7.1 jQuery Migrate 1.4.1 jQuery Migrate 3.5.0 jQuery UI 1.14.1 Replaced YUI Compressor
…ckage The maven-war-plugin exploded goal was bound to the process-classes phase, which runs during `mvn test`. Since resource-server-content has no Java sources, its target/classes directory is never created during the test lifecycle, causing the overlay unpacking to fail. Binding to prepare-package instead ensures the goal only runs during the package lifecycle and later, by which point resource-server-content has been fully packaged and its WAR artifact is available for overlay.
There was a problem hiding this comment.
Pull request overview
This PR updates the resource-server’s front-end dependency set (Bootstrap/jQuery family) and replaces the legacy YUI-based minification/compression pipeline with an esbuild-based approach, including new build-time Node tooling.
Changes:
- Add Bootstrap 5.3.8 (webjar + static content) and new front-end resource versions in
resource-server-content. - Replace YUI Compressor-based JS/CSS compression with esbuild (Java
ProcessBuilderwrapper + Node-driven build step). - Update CI/build configuration to support Node/esbuild during packaging.
Reviewed changes
Copilot reviewed 128 out of 193 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resource-server-webapp/pom.xml | Adds Bootstrap webjar and runs Node/esbuild-based minification during WAR assembly. |
| resource-server-webapp/package.json | Defines Node devDependencies and a minify script for build-time minification. |
| resource-server-webapp/node/npx.cmd | Adds a vendored npx wrapper script for Windows. |
| resource-server-webapp/node/npx | Adds a vendored npx wrapper script for Unix-like shells. |
| resource-server-webapp/node/npm.cmd | Adds a vendored npm wrapper script for Windows. |
| resource-server-webapp/node/npm | Adds a vendored npm wrapper script for Unix-like shells. |
| resource-server-webapp/minify.js | Implements esbuild-based JS/CSS minification over the exploded webapp output. |
| resource-server-utils/src/main/java/org/jasig/resourceserver/utils/taglib/JavaScriptMinificationTag.java | Removes YUI tag-based minification and switches tag behavior to pass-through. |
| resource-server-core/src/test/resources/skin-test1/skin.aggr.xml | Updates expected aggregated/minified asset hashes after compressor change. |
| resource-server-core/src/test/resources/skin-test-incl-overlay/skin.aggr.xml | Updates expected aggregated/minified asset hashes after compressor change. |
| resource-server-core/src/test/resources/skin-complex/superskin/skin.aggr.xml | Updates expected aggregated/minified asset hashes after compressor change. |
| resource-server-core/src/main/java/org/jasig/resource/aggr/ResourcesAggregatorImpl.java | Switches aggregation compression from YUI/Rhino to EsbuildCompressor. |
| resource-server-core/src/main/java/org/jasig/resource/aggr/EsbuildCompressor.java | New Java wrapper that shells out to npx esbuild for JS/CSS minification. |
| resource-server-core/src/main/java/org/jasig/resource/aggr/CommonsLogErrorReporter.java | Deprecates/stubs the old YUI/Rhino error reporter. |
| resource-server-core/pom.xml | Removes YUI Compressor dependency and jarjar shading configuration. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_highlight-soft_75_cccccc_1x100.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_glass_95_fef1ec_1x400.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_glass_75_e6e6e6_1x400.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_glass_75_dadada_1x400.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_glass_65_ffffff_1x400.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/jqueryui/1.14.1/themes/smoothness/images/ui-bg_glass_55_fbf9ee_1x400.png | Adds updated jQuery UI image asset. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/utilities/_api.scss | Adds Bootstrap 5.3.8 SCSS utility API definitions. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/utilities/_api.test.scss | Adds Bootstrap 5.3.8 SCSS utility tests. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/sass-true/runner.js | Adds sass-true test runner for Bootstrap SCSS tests. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/sass-true/register.js | Registers SCSS test loading via require.extensions. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/mixins/_media-query-color-mode-full.test.scss | Adds Bootstrap mixin compilation coverage for media-query color mode. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/mixins/_color-modes.test.scss | Adds Bootstrap mixin tests for color-mode variants. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/mixins/_color-contrast.test.scss | Adds Bootstrap tests around color-contrast/WCAG boundary cases. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/mixins/_box-shadow.test.scss | Adds Bootstrap box-shadow mixin tests. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/mixins/_auto-import-of-variables-dark.test.scss | Adds Bootstrap test for variables-dark import behavior. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/tests/jasmine.js | Adds Jasmine config for running SCSS tests via sass-true. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_visually-hidden.scss | Adds Bootstrap visually-hidden mixins (a11y helpers). |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_utilities.scss | Adds Bootstrap utility generator mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_transition.scss | Adds Bootstrap transition mixin definitions. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_text-truncate.scss | Adds Bootstrap text truncation mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_table-variants.scss | Adds Bootstrap table variant mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_resize.scss | Adds Bootstrap resize mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_reset-text.scss | Adds Bootstrap reset-text mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_pagination.scss | Adds Bootstrap pagination sizing mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_lists.scss | Adds Bootstrap list-unstyled mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_list-group.scss | Adds Bootstrap list-group mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_image.scss | Adds Bootstrap image mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_grid.scss | Adds Bootstrap grid mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_gradients.scss | Adds Bootstrap gradient mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_forms.scss | Adds Bootstrap form validation/state mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_deprecate.scss | Adds Bootstrap deprecation warning mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_container.scss | Adds Bootstrap container mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_color-scheme.scss | Adds Bootstrap prefers-color-scheme mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_color-mode.scss | Adds Bootstrap data-attr/media-query color-mode mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_clearfix.scss | Adds Bootstrap clearfix mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_caret.scss | Adds Bootstrap caret mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_buttons.scss | Adds Bootstrap button variant/size mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_breakpoints.scss | Adds Bootstrap breakpoint functions/mixins. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_box-shadow.scss | Adds Bootstrap box-shadow mixin implementation. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_border-radius.scss | Adds Bootstrap border-radius mixins and helpers. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_banner.scss | Adds Bootstrap banner mixin (version/license header). |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_backdrop.scss | Adds Bootstrap overlay backdrop mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/mixins/_alert.scss | Adds Bootstrap alert variant mixin. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_vr.scss | Adds Bootstrap vertical rule helper styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_visually-hidden.scss | Adds Bootstrap visually-hidden helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_text-truncation.scss | Adds Bootstrap text truncation helper class. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_stretched-link.scss | Adds Bootstrap stretched-link helper class. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_stacks.scss | Adds Bootstrap stack helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_ratio.scss | Adds Bootstrap ratio helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_position.scss | Adds Bootstrap fixed/sticky helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_icon-link.scss | Adds Bootstrap icon-link helpers. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_focus-ring.scss | Adds Bootstrap focus-ring helpers. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_colored-links.scss | Adds Bootstrap colored link helpers. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_color-bg.scss | Adds Bootstrap text-bg helpers. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/helpers/_clearfix.scss | Adds Bootstrap clearfix helper class. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_validation.scss | Adds Bootstrap form validation styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_labels.scss | Adds Bootstrap label styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_input-group.scss | Adds Bootstrap input-group styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_form-text.scss | Adds Bootstrap form-text styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_form-select.scss | Adds Bootstrap select styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_form-range.scss | Adds Bootstrap range input styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_form-control.scss | Adds Bootstrap form-control styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_form-check.scss | Adds Bootstrap checkbox/radio/switch styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/forms/_floating-labels.scss | Adds Bootstrap floating label styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/bootstrap.scss | Adds Bootstrap main SCSS entrypoint. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/bootstrap-utilities.scss | Adds Bootstrap utilities-only SCSS entrypoint. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/bootstrap-reboot.scss | Adds Bootstrap reboot-only SCSS entrypoint. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/bootstrap-grid.scss | Adds Bootstrap grid-only SCSS entrypoint. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_variables-dark.scss | Adds Bootstrap dark-mode variables. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_type.scss | Adds Bootstrap typography styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_transitions.scss | Adds Bootstrap transition helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_tooltip.scss | Adds Bootstrap tooltip styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_toasts.scss | Adds Bootstrap toast styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_tables.scss | Adds Bootstrap table styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_spinners.scss | Adds Bootstrap spinner styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_progress.scss | Adds Bootstrap progress styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_popover.scss | Adds Bootstrap popover styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_placeholders.scss | Adds Bootstrap placeholder styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_pagination.scss | Adds Bootstrap pagination styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_offcanvas.scss | Adds Bootstrap offcanvas styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_nav.scss | Adds Bootstrap nav styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_mixins.scss | Adds Bootstrap mixin import aggregation. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_maps.scss | Adds Bootstrap map helpers/utility maps. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_list-group.scss | Adds Bootstrap list-group styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_images.scss | Adds Bootstrap image helper classes. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_helpers.scss | Adds Bootstrap helper imports. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_grid.scss | Adds Bootstrap grid styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_forms.scss | Adds Bootstrap form imports. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_containers.scss | Adds Bootstrap container styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_close.scss | Adds Bootstrap close button styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_carousel.scss | Adds Bootstrap carousel styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_buttons.scss | Adds Bootstrap button styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_button-group.scss | Adds Bootstrap button-group styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_breadcrumb.scss | Adds Bootstrap breadcrumb styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_badge.scss | Adds Bootstrap badge styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_alert.scss | Adds Bootstrap alert styles. |
| resource-server-content/src/main/webapp/rs/bootstrap/5.3.8/scss/_accordion.scss | Adds Bootstrap accordion styles. |
| resource-server-content/pom.xml | Removes YUI compressor plugin execution from the content module. |
| pom.xml | Updates parent dependency management (removes YUI, attempts to add frontend plugin). |
| .github/workflows/CI.yml | Updates CI matrix (drops Java 8) and adds Node/esbuild install steps. |
Files not reviewed (1)
- resource-server-webapp/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
All for updating libraries, do they need to be embedded in the source?
Could the new versions be added as web jars?
https://www.webjars.org/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new versions of dependencies