Conversation
|
Visit the preview URL for this PR (updated for commit 085de38): https://bt-web-dev-ebf17--pr473-registrationstattix-bs8eaxj7.web.app (expires Thu, 05 Oct 2023 21:20:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a1bf7afe94c954469059b9e3898cf94f4178c379 |
| }; | ||
| for (let i = 0; i < users.length; i++) { | ||
| users = users.filter(user => user.isPartner === false); | ||
| } |
There was a problem hiding this comment.
this can be rewritten the same if you remove the for loop. Notice how you are not using "i" in line 276. See the documentation for array.filter to see how filter operates on the entire array and not just a single item.
| "optional": true | ||
| }, | ||
| "node_modules/@types/react": { | ||
| "version": "18.2.9", |
There was a problem hiding this comment.
package-lock shouldn't have changed here because you didn't add any new dependencies. I think you need to rebase the branch onto the latest version of dev, making sure to git pull.
Please try to make it so there are no changes to package lock
ddennis924
left a comment
ddennis924
left a comment
There was a problem hiding this comment.
Good work on making your first PR! To more clearly match the ticket description, instead of filtering, I think the best way to approach it is to have a separate stat tab for partners, so we can still see how many partners are registered
…strationStatTix
4 participants
🎟️ Ticket(s): Closes # Add Partner Count to registration state
👷 Changes: The ticket was slightly modified. The stats show just the participant stats and no partner stats instead of showing the number of partners and participants separately.
Wait! Before you merge, have you checked the following:
📷 Screenshots
Total number of participants were 8 and number of partners were 4.
The total on the stat is 8, showing just the participants.
Checklist