Open
Conversation
|
Visit the preview URL for this PR (updated for commit 1b9a3ce): https://bt-web-dev-ebf17--pr476-seepreviousmembersta-2s05ebj7.web.app (expires Fri, 20 Oct 2023 02:59:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a1bf7afe94c954469059b9e3898cf94f4178c379 |
ddennis924
approved these changes
Nov 17, 2023
ddennis924
reviewed
Feb 6, 2024
Member
ddennis924
left a comment
ddennis924
left a comment
There was a problem hiding this comment.
what if we need to add new years? how is that handled
ddennis924
reviewed
Feb 6, 2024
| <MenuItem value="2024">2024</MenuItem> | ||
| </Select> | ||
| </FormControl> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #
👷 Changes: A brief summary of what changes were introduced.
Added a button to choose and view member stats by year.
In the first photo, we can see the default setting is 2024 and it shows 12 data points.
In the second photo, when the button is clicked, it opens up the list of years to choose from.
In the third photo, we've selected 2021 and it shows 519 data points.
The fourth photo shows a mobile view.
💭 Notes: Any additional things to take into consideration.
How thoroughly am I supposed to test this? I'm not sure if I've covered all bases.
Wait! Before you merge, have you checked the following:
📷 Screenshots
(prefer animated gif)
Checklist