fix the error example to pass a constructor to fx.Provide#1290
Open
c-tonneslan wants to merge 1 commit into
Open
fix the error example to pass a constructor to fx.Provide#1290c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The example's fx.Provide branch was passing a *http.Server value directly. fx.Provide expects a constructor function, so the moment PORT was set and that path actually ran, the app failed with "must provide constructor function." The example happened to still pass its doctest because the doctest only exercised the PORT-unset branch. Wrap the value in a closure so the second branch behaves as advertised the first time someone copies the snippet. Closes uber-go#1252. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1252.
The example's `fx.Provide` branch was passing a `*http.Server` value directly. `fx.Provide` expects a constructor function, so the moment `PORT` was set and that path actually ran, the app failed with "must provide constructor function." The doctest happened to still pass because it only exercised the PORT-unset branch.
Wrap the value in a closure so the second branch behaves as advertised the first time someone copies the snippet.