Upgrade go version to 1.21 in go.mod#1425
Open
arukiidou wants to merge 3 commits intouber-go:masterfrom
Open
Conversation
Contributor
Author
Contributor
|
Hey @arukiidou - my understanding is that the go line in a library's go.mod file now sets a requirement for all consumers of the library, so I actually think we may want to be more conservative when it comes to updating it so as to not require all consumers to upgrade, unless there's a very good reason. But I'm open to other thoughts! |
Contributor
Author
|
Yes, it will need to upgrade most of go.mods to pass the test. Why upgrades?
You make a good point , could postpone this for several months. |
Contributor
|
Hey @arukiidou -
If it's ok with you, I think we should probably wait on this. |
Contributor
Author
|
Ok, I understood that this is still early. Please let me know when the time comes. |
cd0bcee to
436c470
Compare
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
436c470 to
064241d
Compare
Contributor
Author
|
@JacobOaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I upgraded go version to 1.21 in go.mod.
copy of #1181