Fix queries without arguments #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #63 introduced a bug that broke queries that aren't using arguments. Any queries without arguments now return the following error:
The problem is that the
buildExecutionParams
function returns an empty but non-nil
slice when no args are provided. That ultimately gets passed as theExecutionParameters
in the call toStartQueryExecution
. That in turn causes a validation error in the underlying Athena library, because it validates that the slice has a length of at least 1 if it's non-nil. See themin:"1" type:"list"
struct tag on theExecutionParameters
field in theStartQueryExecutionInput
struct.This fixes the issue by returning a
nil
slice instead of an empty slice if no args are provided.