Set refresh: 0 by default in custom templates#113
Merged
albertyw merged 1 commit intouber:masterfrom Aug 27, 2025
Merged
Conversation
|
|
garkhipov
commented
Aug 25, 2025
| }); | ||
| assert.equal(customWithAllValue.state.includeAll, true); | ||
| assert.deepEqual(customTemplate.state.current, {}); | ||
| assert.deepEqual(customWithAllValue.state.current, {}); |
Contributor
Author
There was a problem hiding this comment.
These were presumably a copy-paste error in the original change.
albertyw
reviewed
Aug 26, 2025
Member
albertyw
left a comment
albertyw
left a comment
There was a problem hiding this comment.
Changes should be ok but can you rebase this PR to get a passing build?
garkhipov
force-pushed
the
tpl-custom-refresh-0
branch
from
18c028b to
eaf19c2
Compare
Contributor
Author
|
Rebased, all green 👍 |
albertyw
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting refresh to 1 by default (#87) was found to break other dashboards relying on static variable options. Changing to 0.