Fix crash when referencing non-existent target ref ID#128
Merged
albertyw merged 1 commit intouber:masterfrom Jan 23, 2026
Merged
Fix crash when referencing non-existent target ref ID#128albertyw merged 1 commit intouber:masterfrom
albertyw merged 1 commit intouber:masterfrom
Conversation
The handleRefTargets function used Array.find() with a non-null assertion to look up target references by refId. When a non-existent ref was referenced (e.g., #Z when only #A and #B exist), find() returned undefined and accessing .target on it caused a runtime TypeError. This change adds proper error handling to throw a descriptive error message that includes the invalid ref and lists all available refs, making debugging much easier for users.
albertyw
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
handleRefTargetsfunction insrc/panels/graph.tsusedArray.find()with a TypeScript non-null assertion (!) to look up target references by refId:When a target referenced a non-existent ref (e.g.,
#Zwhen only#Aand#Bexist),find()returnedundefinedand accessing.targeton it caused:Solution
Added explicit null checking with a descriptive error message that includes:
Example error message:
Testing