feat: add pure-Go grid traversal (k-ring/disk/ring) to x/h3go - #127
Open
justinhwang wants to merge 1 commit into
Open
feat: add pure-Go grid traversal (k-ring/disk/ring) to x/h3go#127justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
Coverage Report for CI Build 30594620870Coverage at 100.0% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Implement the grid traversal family in pure Go, verified against the
cgo reference:
- GridDisk (+ method), GridDisksUnsafe
- GridDiskDistances / Unsafe / Safe (+ methods)
- GridRing / GridRingUnsafe (+ methods)
- Cell.IsNeighbor
The core is neighborRotations, which steps to an adjacent cell while
threading base-cell rotation state and pentagon distortion. The fast
("Unsafe") spiral fails near pentagons and falls back to a breadth-first
"Safe" traversal. Adds the base-cell neighbor/rotation tables and the
Class II/III digit-adjustment tables, plus ErrPentagon and a setBaseCell
helper.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
justinhwang
force-pushed
the
justinhwang/purego-phase-d
branch
from
July 31, 2026 00:49
316e23e to
af54dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the grid traversal family in pure Go, verified against the cgo reference:
The core is neighborRotations, which steps to an adjacent cell while threading base-cell rotation state and pentagon distortion. The fast ("Unsafe") spiral fails near pentagons and falls back to a breadth-first "Safe" traversal. Adds the base-cell neighbor/rotation tables and the Class II/III digit-adjustment tables, plus ErrPentagon and a setBaseCell helper.