feat: Implement GridDisksUnsafe, GridDiskDistancesUnsafe, GridDiskDistancesSafe#84
Merged
jogly merged 3 commits intouber:masterfrom Jun 6, 2025
justinhwang:justinhwang/bindings
Merged
feat: Implement GridDisksUnsafe, GridDiskDistancesUnsafe, GridDiskDistancesSafe#84jogly merged 3 commits intouber:masterfrom justinhwang:justinhwang/bindings
jogly merged 3 commits intouber:masterfrom
justinhwang:justinhwang/bindings
Conversation
Pull Request Test Coverage Report for Build 15495955929Details
💛 - Coveralls |
…tancesSafe Implements remaining bindings for C library functions. This includes: - GridDisksUnsafe - GridDiskDistancesUnsafe - GridDiskDistancesSafe which are listed in the API Reference[0]. - 0: https://h3geo.org/docs/api/traversal
isaacbrodsky
requested review from
ajfriend,
dfellis,
isaacbrodsky,
jogly,
nrabinowitz and
zachcoleman
zachcoleman
reviewed
Jun 6, 2025
zachcoleman
previously approved these changes
Jun 6, 2025
Collaborator
zachcoleman
left a comment
zachcoleman
left a comment
There was a problem hiding this comment.
This looks good to me. I will let another reviewer also take a look.
jogly
previously approved these changes
Jun 6, 2025
Collaborator
jogly
left a comment
jogly
left a comment
There was a problem hiding this comment.
awesome! can you update the README C to Go table with your addition? I missed this in the ring PR, so if you can sneak that mapping into the table as well that would be appreciated.
jogly
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements remaining bindings for C library functions.
This includes:
which are listed in the API Reference[0].