Skip to content

feat: Slightly optimize CellsToMultiPolygon and LatLng#String#86

Merged
jogly merged 3 commits intouber:masterfrom
justinhwang:justinhwang/tostring
Jun 6, 2025
Merged

feat: Slightly optimize CellsToMultiPolygon and LatLng#String#86
jogly merged 3 commits intouber:masterfrom
justinhwang:justinhwang/tostring

Conversation

@justinhwang
Copy link
Copy Markdown
Collaborator

Before:

BenchmarkCellsToMultiPolygon-16       589149          2022 ns/op         344 B/op          8 allocs/op
BenchmarkLatLng_String-16        6480610           184.2 ns/op        40 B/op          3 allocs/op

After:

BenchmarkCellsToMultiPolygon-16       600781          2006 ns/op         200 B/op          5 allocs/op
BenchmarkLatLng_String-16            9569876           126.4 ns/op        24 B/op          1 allocs/op

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 6, 2025

Pull Request Test Coverage Report for Build 15497156683

Details

  • 39 of 46 (84.78%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 98.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
h3.go 39 46 84.78%
Files with Coverage Reduction New Missed Lines %
h3.go 1 98.15%
Totals Coverage Status
Change from base Build 15497079248: -0.8%
Covered Lines: 691
Relevant Lines: 704

💛 - Coveralls

jogly
jogly previously approved these changes Jun 6, 2025
Copy link
Copy Markdown
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Before:
```
BenchmarkCellsToMultiPolygon-16       589149          2022 ns/op         344 B/op          8 allocs/op
BenchmarkLatLng_String-16        6480610           184.2 ns/op        40 B/op          3 allocs/op
```

After:
```
BenchmarkCellsToMultiPolygon-16       600781          2006 ns/op         200 B/op          5 allocs/op
BenchmarkLatLng_String-16            9569876           126.4 ns/op        24 B/op          1 allocs/op
```
@justinhwang
Copy link
Copy Markdown
Collaborator Author

@jogly thanks for the quick review! had to rebase

Copy link
Copy Markdown
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 x2

@jogly jogly merged commit d6054b3 into uber:master Jun 6, 2025
5 of 6 checks passed
@justinhwang justinhwang deleted the justinhwang/tostring branch June 6, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants