Draft: Attempt at Mac OS compilation by chrisirhc · Pull Request #184 · uber/hermetic_cc_toolchain

chrisirhc · 2024-06-16T13:04:08Z

Attempt to get a working macos branch.
This is a continuation of the work in https://github.com/motiejus/hermetic_cc_toolchain/tree/macos .

NOTE: I have no idea what I'm doing. I'm piecing together the previous threads about sysroot from the readme.
I have no idea what the zig or gcc options mean.

There are a number of hacks in this branch, so this is still WIP.

TODOs:

Commits are messy and aren't yet cleaned up for review
Identify what's hacky/needs to be removed
Verify the options
Test with more use cases

Fixes #10

motiejus@mtwork:/code/bazel-zig-cc$ bazel build --spawn_strategy=local --platforms @zig_sdk//libc_aware/platform:macos_aarch64_sdk.13.1 test/c:which_libc INFO: Analyzed target //test/c:which_libc (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //test/c:which_libc up-to-date: bazel-bin/test/c/which_libc INFO: Elapsed time: 0.071s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action motiejus@mtwork:/code/bazel-zig-cc$ file bazel-bin/test/c/which_libc bazel-bin/test/c/which_libc: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE> motiejus@mtwork:/code/bazel-zig-cc$

But need to go back to see what hacks I added

bazel build --spawn_strategy=local --platforms @zig_sdk//libc_aware/platform:macos_aarch64_sdk.14.2 test/c:which_libc --sandbox_debug -s INFO: Build completed successfully, 4 total actions

chrisirhc · 2024-06-16T13:07:59Z

toolchain/private/defs.bzl

+        "external/hermetic_cc_toolchain~~toolchains~macos_sdk_{}".format(macos_sdk_version),
+        "-F",
+        "external/hermetic_cc_toolchain~~toolchains~macos_sdk_{}/Frameworks".format(macos_sdk_version),
+        "-L",
+        "external/hermetic_cc_toolchain~~toolchains~macos_sdk_{}/lib".format(macos_sdk_version),


I'm not sure why external/macos_sdk_… path doesn't work. Is it how the repository was defined? I'm not sure if this is idiomatic bazel to depend on an external path with ~s, I'd imagine these are 'non-public' paths.

These are bzlmod canonical repo paths, which are not guaranteed to be deterministic. You'll want to instead resolve them with some combination of Label and repository_ctx.path

chrisirhc · 2024-06-16T13:10:24Z

toolchain/zig-wrapper.zig

+    // HACK: if OS is macos, then force the ABI triple to "none".
+    if (!mem.eql(u8, got_os, "macos"))
+        return RunMode{ .cc = triple };
+
+    if (mem.eql(u8, got_arch, "aarch64"))
+        return RunMode{ .cc = "aarch64-macos-none" };
+
+    if (mem.eql(u8, got_arch, "x86_64"))
+        return RunMode{ .cc = "x86_64-macos-none"};
+


I think these hacks are to get macos-arm64-sdk.14.2 to be recognized by zig with an expected target ABI.

chrisirhc · 2024-06-16T13:12:43Z

toolchain/private/defs.bzl

-            "libc/darwin",
-            "libc/include/any-macos-any",
+          "libc/include/any-macos-any",
        ] + _INCLUDE_TAIL,
-        linkopts = ["-Wl,-headerpad_max_install_names"],
+        linkopts = macos_sdk_opts,
        dynamic_library_linkopts = ["-Wl,-undefined=dynamic_lookup"],
        supports_dynamic_linker = True,
+        cxx_builtin_include_directories = [
+          "external/hermetic_cc_toolchain~~toolchains~macos_sdk_{}/include".format(macos_sdk_version)
+        ],
+        sdk_include_files = [
+          "@macos_sdk_{}//:Frameworks".format(macos_sdk_version),
+          # "@macos_sdk_{}//:usr_include".format(macos_sdk_version),
+        ],
+        sdk_lib_files = ["@macos_sdk_{}//:usr_lib".format(macos_sdk_version)],


I found these by trial and error and compiling against a target that expects Mac OS SDK ( the example in #10 (comment) )

fatal error: 'CFNetwork/CFProxySupport.h' file not found

hit error: unsupported linker arg: -no_pie

pcj · 2024-06-30T17:03:20Z

@chrisirhc nice work so far! Happy to help test this when ready.

chrisirhc · 2024-07-11T13:23:42Z

Realized that hexops is an incomplete sysroot, so I went with unpacking a pkg.
Now I'm hitting:

external/go_sdk/pkg/tool/darwin_amd64/link: running external/hermetic_cc_toolchain~~toolchains~zig_sdk/tools/aarch64-macos-sdk.14.4/c++ failed: exit status 1
error: symbol _runtime.covctrs not attached to any (sub)section
    note: while parsing /var/folders/rg/8yzx68lj705cjn8q0pzxv59w0000gn/T/go-link-1625103760/go.o

link: error running subcommand external/go_sdk/pkg/tool/darwin_amd64/link: exit status 2

I believe it's the issue reported in ziglang/zig#20243

But I guess this is progress.

jvolkman · 2025-01-22T05:46:06Z

Hi @chrisirhc - just wondering whether you're still working on this? Or would you be open to someone else picking up from here? (not necessarily me!)

chrisirhc · 2025-01-22T08:37:10Z

Hi @chrisirhc - just wondering whether you're still working on this? Or would you be open to someone else picking up from here? (not necessarily me!)

I'm not actively working on this. It's currently in a stuck state. I'm not sure what to try. Definitely open to someone else picking it up from here.

chrisirhc · 2025-03-17T07:22:40Z

To note:
https://news.ycombinator.com/item?id=43268431 mentions https://github.com/tpoechtrager/osxcross

motiejus and others added 7 commits June 13, 2024 22:51

got some output using 14.2

adc3cfb

But need to go back to see what hacks I added

found the right libc location

db2b76f

add back zig-wrapper hack (Fix UnknownApplicationBinaryInterface)

206507d

linking seems to work

47b1b9e

bazel build --spawn_strategy=local --platforms @zig_sdk//libc_aware/platform:macos_aarch64_sdk.14.2 test/c:which_libc --sandbox_debug -s INFO: Build completed successfully, 4 total actions

seems to work with the hermetic_cc_toolchain prefix in path

1f7c195

also seems to work

e60f446

chrisirhc commented Jun 16, 2024

View reviewed changes

chrisirhc added 11 commits June 16, 2024 21:17

fix bazel test failure

012b0f7

attempt to fix tests

ddf7d1d

another attempt at adding sdk targets

be7c7cf

fix target name

840b73a

NOT WORKING hack to get deps

1ef74bc

NOT WORKING: add sysroot with skylib directory

46dfd43

cleanup code back to not finding the Frameworks folder

15af3a1

fatal error: 'CFNetwork/CFProxySupport.h' file not found

seems to work again

8c3382e

hit error: unsupported linker arg: -no_pie

remove expansion

500b184

remove deadcode

162f697

register corrct name

4f8b860

chrisirhc added 4 commits July 10, 2024 21:20

first stab, not working due to symlink

e1a9f87

fix recursive symlink issue

071666b

fix path to Frameworks

e5e5d27

fix path to usr/lib

bc2fca5

chrisirhc added 4 commits July 11, 2024 21:31

remove get_auth, only avilable in newer bazel versions

19e79e2

upgrade to bazel 7.1 for is_dir

f46d1f9

switch to tar.gz

d5fe51f

make sure usr_include is included

24dce21

albertocavalcante mentioned this pull request Aug 13, 2024

Cross-Compile: add go_binary targets for linux and windows for both amd64 and arm64 architectures albertocavalcante/garf#3

Merged

clean up changes to ease review

7af1503

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: Attempt at Mac OS compilation#184

Draft: Attempt at Mac OS compilation#184
chrisirhc wants to merge 27 commits intouber:mainfrom
chrisirhc:macos

chrisirhc commented Jun 16, 2024 •

edited

Loading

Uh oh!

chrisirhc Jun 16, 2024

Uh oh!

jvolkman Jun 18, 2024

Uh oh!

chrisirhc Jun 16, 2024

Uh oh!

chrisirhc Jun 16, 2024

Uh oh!

pcj commented Jun 30, 2024

Uh oh!

chrisirhc commented Jul 11, 2024 •

edited

Loading

Uh oh!

jvolkman commented Jan 22, 2025

Uh oh!

chrisirhc commented Jan 22, 2025

Uh oh!

chrisirhc commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chrisirhc commented Jun 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisirhc Jun 16, 2024

Choose a reason for hiding this comment

Uh oh!

jvolkman Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

chrisirhc Jun 16, 2024

Choose a reason for hiding this comment

Uh oh!

chrisirhc Jun 16, 2024

Choose a reason for hiding this comment

Uh oh!

pcj commented Jun 30, 2024

Uh oh!

chrisirhc commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvolkman commented Jan 22, 2025

Uh oh!

chrisirhc commented Jan 22, 2025

Uh oh!

chrisirhc commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chrisirhc commented Jun 16, 2024 •

edited

Loading

chrisirhc commented Jul 11, 2024 •

edited

Loading