fix: provide cc_toolchain artifacts required for assembly actions #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, having an assembly source file as srcs of a cc_library will fail because compiler files are missing from the sandbox: Like so: ``` src/main/tools/process-wrapper-legacy.cc:80: "execvp(external/hermetic_cc_toolchain~~toolchains~zig_sdk/tools/x86_64-linux-gnu.2.36/c++, ...)": No such file or directory ```
Contributor
Author
|
Cc @linzhp small yet important one ! 🙏 |
Contributor
Author
|
Thanks for the quick merge. Would it be possible to ask for a release at this point ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, having an assembly source file as srcs of a cc_library will fail because compiler files are missing from the sandbox:
This PR fixes that.