Add path to add extra settings to toolchains#213
Merged
Conversation
This will allow toolchains to be configurably more restrictive.
|
|
Contributor
Author
|
Hey @linzhp, do you think you could take a look? |
linzhp
approved these changes
Oct 4, 2025
Contributor
|
Sorry, there is a formatting issue with this PR: https://github.com/uber/hermetic_cc_toolchain/actions/runs/18246375866/job/51954853123 Can you fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow toolchains to be configurably more restrictive, e.g. by requiring a setting to be enabled in order to select the hermetic toolchains.
This could be a solution to #205.