Add extra_{exec,target}_compatible_with extensions
#240
+82
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
linzhp
reviewed
Jan 25, 2026
| doc = "Each setting is added to every toolchain to make them more restrictive", | ||
| ) | ||
|
|
||
| _extra_target_compatible_with = tag_class( |
Contributor
There was a problem hiding this comment.
with these two new tag classes, do you think we still need _extra_target_settings?
Contributor
Author
There was a problem hiding this comment.
I don't feel strongly either way, for the project that motivated me to send this PR I definitely won't need it now that I can specify with target_compatible_with, but I could imagine situations where it might be convenient to control which toolchain is used with settings rather than constraints.
Contributor
Author
|
Thanks for the speedy response 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
extra_exec_compatible_withandextra_target_compatible_withas extensions so that users can control whether the toolchains generated by hermetic_cc_toolchain are selected.This is intended to fix #205