Pass explicit -target to zig on macOS - #258
Merged
Merged
Conversation
sywhang
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 26 (Xcode/CommandLineTools with MacOSX26.x.sdk), bazel build //rules:cp and ci/zig-utils both fail with undefined-symbol link errors (_abort, _getenv, _sigaction, __availability_version_check, …).
Root cause
Both code paths invoke zig without a -target, so zig links against the host macOS SDK's libSystem.tbd. Zig 0.14.0's TAPI parser can't parse the tbd shipped with newer Xcode SDKs (ziglang/zig#23324) and silently yields zero symbols. Confirmed by isolation: the same commands with -target aarch64-macos-none or an older SDK sysroot link and run.
Fix
Pass an explicit -target on macOS only, so zig links against its bundled hermetic libc stubs instead of the host SDK. Linux and Windows are untouched — they build natively as before (Linux glibc detection works, Windows bundles mingw-w64 libc).