Parallelize encoding of a single row #546
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selitvin
force-pushed
the
parallel_encoding
branch
from
367736c to
5fe4e11
Compare
Fields that contain data that is not natively supported by Parqyet format, such as numpy arrays, are serialized into byte arrays. Images maybe compressed using png or jpeg compression. Serializing fields on a thread pool speeds up this process in some cases (e.g. a row contains multiple images). This PR adds a pool executor argument to `dict_to_spark_row` enabling user to pass a pool executor that would be used for parallelizing this serialization. If no pool executor is specified, the encoding/serialization is performed on the caller thread.
selitvin
force-pushed
the
parallel_encoding
branch
from
5fe4e11 to
3fe68d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 82.88% 85.99% +3.11%
==========================================
Files 85 87 +2
Lines 4721 4935 +214
Branches 744 783 +39
==========================================
+ Hits 3913 4244 +331
+ Misses 678 568 -110
+ Partials 130 123 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yevgeni Litvin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing data into a petastorm dataset. Before a pyspark sql.Row
object is created, fields containing data that is not natively supported
by Parqyet format, such as numpy arrays, are serialized into byte
arrays. Images maybe compressed using png or jpeg compression.
Serializing fields on a thread pool speeds up this process in some
cases (e.g. a row contains multiple images).