Repository Language Configuration + Java Support#15
Merged
Conversation
JamyDev
requested changes
Sep 2, 2025
Contributor
Author
|
@JamyDev - Addressed comments, and removed the monorepo names from source entirely! (And added explicit test for bazel-out) |
JamyDev
reviewed
Sep 2, 2025
JamyDev
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of getting Java specific features (Java Indexing) working at Stripe, we needed to remove the need for hardcoded repository names used internally at Uber. To allow for this to be 'company agnostic' I added a
languagessection to theentity.MonorepoConfigEntrythat allows each repo to have a set of languages that are enabled for it. (Currently only addingjavato the list changes anything.)As part of this, the way repositories at Stripe are structured, we have
/src/twice in our paths due to repository locations on disk. To allow this to work in a generic fashion,GetJavaTargetnow operates by looking at the directory tree forBUILD(.bazel)?files to return the appropriate target directory based on the nearest parent Bazel build file.To allow for tests using
GetJavaTargetto operate on the filesystem rather than delimiters in strings, the tests needed to be wired up for providing thefs.UlspFSto allow for mocked file systems.Type of Change
lm/fievelrepository. It will need to have the following Yaml configuration changes inbase.yamlto enable Java language supportComponent(s) Affected
Testing
bazel test //...)//...is broken on my machine, butbazel test //src/ulsp/...was used.Manual Testing Details
Describe how you tested these changes:
Checklist
Screenshots/Logs (if applicable)
These are screenshots from usages in our internal Java Monorepo. Certain pieces redacted for security purposes.
CodeLenses in file:

Clicking

Sync FileCodeLense:(I haven't run a full sync yet - @murray-stripe has that in his branch, but this changeset does not change that flow)
Clicking

BuildCodeLense:Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Additional Notes
GetJavaTargetmethod - depending on where the buildfiles are located internally at Uber, it might diverge. Let me know if it's not what it's intended purpose is and we can adjust.