Conversation
JamyDev
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an additional "out/" directory prefix in the generated scip files making use of
jar.short_pathas part of the declared output path.This fixes a bug when the label is an alias to the jar (or multiple levels of aliases + select statements). In some circumstances Bazel will error indicating that the delcared file or directory is not within the same package, triggering this error. This is remediated simply by declaring a relative
"out/"prefix on the path.Type of Change
Component(s) Affected
Testing
bazel test //...)Manual Testing Details
Describe how you tested these changes:
aliasandselectindirection, within and outside of the main repostiory/workspace.Checklist
Screenshots/Logs (if applicable)
Include any relevant screenshots, logs, or output that demonstrates the changes.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Additional Notes
Any additional information that reviewers should know about this PR.