Skip to content

[bsp_server/indexer] update output paths using jar.short_path#17

Merged
JamyDev merged 1 commit intouber:mainfrom
murray-stripe:murray-private/aspect-fixes
Sep 8, 2025
Merged

[bsp_server/indexer] update output paths using jar.short_path#17
JamyDev merged 1 commit intouber:mainfrom
murray-stripe:murray-private/aspect-fixes

Conversation

@murray-stripe
Copy link
Copy Markdown
Contributor

@murray-stripe murray-stripe commented Sep 5, 2025

Description

Adds an additional "out/" directory prefix in the generated scip files making use of jar.short_path as part of the declared output path.

This fixes a bug when the label is an alias to the jar (or multiple levels of aliases + select statements). In some circumstances Bazel will error indicating that the delcared file or directory is not within the same package, triggering this error. This is remediated simply by declaring a relative "out/" prefix on the path.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...)
  • I have tested this manually with a real project

Manual Testing Details

Describe how you tested these changes:

  • IDE used for testing: VS Code
  • Project(s) tested against: Internal company repository
  • Specific features/scenarios verified: Sync and code-generation with targets through alias and select indirection, within and outside of the main repostiory/workspace.

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

@murray-stripe murray-stripe changed the title update output paths using jar.short_path [bsp_server/indexer] update output paths using jar.short_path Sep 5, 2025
@JamyDev JamyDev merged commit f4efc98 into uber:main Sep 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants