Skip to content

chore(scip-registry) Replace ulsp/controller/scip partialScipRegistry with the scip-lib/registry one#32

Merged
zerunz merged 2 commits intouber:mainfrom
zerunz:zerunz/replace
Nov 8, 2025
Merged

chore(scip-registry) Replace ulsp/controller/scip partialScipRegistry with the scip-lib/registry one#32
zerunz merged 2 commits intouber:mainfrom
zerunz:zerunz/replace

Conversation

@zerunz
Copy link
Copy Markdown
Collaborator

@zerunz zerunz commented Nov 3, 2025

Description

Replace the partialScipRegistry under controller with the scip-lib/registry one which already implemented all required functions for Registry internface. In this way, we can get rid of SymbolData, FileInfo, and PackageMeta since they are unnecessary and not very efficient datatype. This is a first step in addressing #11

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...)
  • I have tested this manually with a real project

Manual Testing Details

Launched ulsp service in scip-lsp repo, checked language intelligence under this directory, it works fine

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 3, 2025

CLA assistant check
All committers have signed the CLA.

@zerunz zerunz changed the title chore(scip-registry) Replace ulsp/controller/scip partialScipRegistry… chore(scip-registry) Replace ulsp/controller/scip partialScipRegistry with the scip-lib/registry one Nov 4, 2025
@zerunz zerunz merged commit 8794951 into uber:main Nov 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants