Conversation
… with the scip-lib/registry one
JamyDev
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the partialScipRegistry under controller with the scip-lib/registry one which already implemented all required functions for Registry internface. In this way, we can get rid of SymbolData, FileInfo, and PackageMeta since they are unnecessary and not very efficient datatype. This is a first step in addressing #11
Type of Change
Component(s) Affected
Testing
bazel test //...)Manual Testing Details
Launched ulsp service in scip-lsp repo, checked language intelligence under this directory, it works fine
Checklist
Screenshots/Logs (if applicable)
Include any relevant screenshots, logs, or output that demonstrates the changes.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Additional Notes
Any additional information that reviewers should know about this PR.