Skip to content

docs: rewrite stale CLAUDE.md sections to match current code (audit #9) - #255

Merged
sbalabanov merged 1 commit into
mainfrom
audit/fix-09-claudemd-rewrite
Jul 31, 2026
Merged

docs: rewrite stale CLAUDE.md sections to match current code (audit #9)#255
sbalabanov merged 1 commit into
mainfrom
audit/fix-09-claudemd-rewrite

Conversation

@sbalabanov

Copy link
Copy Markdown
Contributor

Summary

CLAUDE.md described a deleted generation of the error, metrics, caching, and cancellation systems. This PR rewrites every stale section to match the code on main today; every symbol and file path named in the doc has been verified against the source.

  • Error Classification: replaced core/common, ClassifiedError, common.WithReason, ErrorTypeUser/ErrorTypeInfra, failureReason* constants with the real core/errors system (TangoError, NewUser/NewInfra/NewInfraRetryable, GetErrorCode, errors.Fields); fixed storage.NotFoundError to storage.ErrNotFound + IsNotFound()
  • Controllers: replaced stale calls/success/failure counter pattern with metrics.Begin start counter + op.Complete finish histogram tagged result, plus failures{error_code} counter
  • Orchestrator: replaced common.WithReason(reason, errorType, err) with the real per-cause classifiers (classifyLeaseError, classifyGitError, classifyBazelClientError)
  • Caching: moved helpers from core/common to core/cachekey; replaced blanket best-effort claim with the two-tier policy (identity-bearing reads fail-fast, compared-targets best-effort); documented controller's read-through caching role
  • Cancellation: replaced context.WithoutCancel with the real appCtx pattern
  • Project Layout: added entity/, mapper/, internal/, observability/metrics/, integration/, docs/, core/cachekey/, core/errors/; removed nonexistent common
  • Makefile: relaxed alphabetical-sort + auto-help claim to match reality (hand-written help)
  • Make Targets: added missing bench, test-integration, cover, lint, version

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review July 31, 2026 01:46
@sbalabanov
sbalabanov requested review from a team as code owners July 31, 2026 01:46
@sbalabanov
sbalabanov merged commit 3e6c9aa into main Jul 31, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants