docs: rewrite stale CLAUDE.md sections to match current code (audit #9) - #255
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
xytan0056
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md described a deleted generation of the error, metrics, caching, and cancellation systems. This PR rewrites every stale section to match the code on main today; every symbol and file path named in the doc has been verified against the source.
core/common,ClassifiedError,common.WithReason,ErrorTypeUser/ErrorTypeInfra,failureReason*constants with the realcore/errorssystem (TangoError,NewUser/NewInfra/NewInfraRetryable,GetErrorCode,errors.Fields); fixedstorage.NotFoundErrortostorage.ErrNotFound+IsNotFound()calls/success/failurecounter pattern withmetrics.Beginstart counter +op.Completefinish histogram taggedresult, plusfailures{error_code}countercommon.WithReason(reason, errorType, err)with the real per-cause classifiers (classifyLeaseError,classifyGitError,classifyBazelClientError)core/commontocore/cachekey; replaced blanket best-effort claim with the two-tier policy (identity-bearing reads fail-fast, compared-targets best-effort); documented controller's read-through caching rolecontext.WithoutCancelwith the realappCtxpatternentity/,mapper/,internal/,observability/metrics/,integration/,docs/,core/cachekey/,core/errors/; removed nonexistentcommonbench,test-integration,cover,lint,version🤖 Generated with Claude Code