Support separate AWS roles for build and upload steps#10
Merged
Conversation
furkansahin
requested changes
Feb 2, 2026
furkansahin
left a comment
furkansahin
left a comment
Member
There was a problem hiding this comment.
I don't understand the s3_prefix related change. Is that because you're trying to take a precaution for overwriting an image in s3? Why would it be necessary considering the AMIs are the end product? We also already delete the image from s3 at the end of the run.
Member
|
Can you also rewrite the commit following the same guideline in |
Collaborator
Author
The path is now based on |
iamKunalGupta
force-pushed
the
ci-more-secure
branch
from
125561d to
fc7853a
Compare
iamKunalGupta
changed the title
iamKunalGupta
force-pushed
the
ci-more-secure
branch
from
fc7853a to
daafaed
Compare
iamKunalGupta
force-pushed
the
ci-more-secure
branch
from
35d0a8a to
5e7b176
Compare
serprex
pushed a commit
to serprex/postgres-vm-images
that referenced
this pull request
Mar 20, 2026
The workflow previously used a single AWS authentication method throughout all steps. This adds support for configuring separate AWS roles for different operations: - aws_build_role_arn: Role assumed during build.sh execution - aws_role_arn: Role used for AMI upload and creation - Fallback to access keys when roles are not specified - Additional security options (KMS encryption, custom vmimport role) aws_ami_regions can now contain AWS accounts in the for of: `region:accountId1:accountId2,region2:...`, to which now the workflow shares the AMI IDs. If for a region, an accountId is not present, the workflow falls back to making the AMI public for that region/ Also adds workflow inputs for image_prefix and run_apt_upgrade to provide more control over build customization.
furkansahin
force-pushed
the
ci-more-secure
branch
from
5e7b176 to
6c0b32e
Compare
furkansahin
approved these changes
Mar 26, 2026
iamKunalGupta
added a commit
to iamKunalGupta/postgres-vm-images
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow previously used a single AWS authentication method
throughout all steps. This adds support for configuring separate
AWS roles for different operations:
aws_ami_regions can now contain AWS accounts in the for of:
region:accountId1:accountId2,region2:..., to which now the workflowshares the AMI IDs. If for a region, an accountId is not present, the
workflow falls back to making the AMI public for that region/
Also adds workflow inputs for image_prefix and run_apt_upgrade to
provide more control over build customization.