Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add git attributes #37

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat: add git attributes #37

merged 1 commit into from
Feb 18, 2025
+3 −0

Conversation

whilefoo
Copy link
Contributor

@whilefoo whilefoo commented Feb 18, 2025 •
edited
Loading

Resolves ubiquity-os-marketplace/text-conversation-rewards#275
Related to #29

This will prevent maxing out rewards due to change from yarn.lock to bun.lock, we should also add this to the template.

@whilefoo whilefoo requested a review from rndquu as a code owner February 18, 2025 12:16
@ubiquity-os ubiquity-os bot marked this pull request as draft February 18, 2025 12:17
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Feb 18, 2025 

! You need to link an issue before converting the pull request to ready for review.

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Feb 18, 2025 •
edited
Loading

@whilefoo whilefoo marked this pull request as ready for review February 18, 2025 12:18
@ubiquity-os ubiquity-os bot marked this pull request as draft February 18, 2025 12:18
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Feb 18, 2025 

! You need to link an issue before converting the pull request to ready for review.

@whilefoo whilefoo marked this pull request as ready for review February 18, 2025 12:19
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Feb 18, 2025 

! Error fetching issue, Aborting

gentlementlegen
gentlementlegen approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine although I don't see static/dist/ file path with any content so I am not sure why you added it, is it where the build happens? It doesn't seem to be committed

@whilefoo
Copy link
Contributor Author

Looks fine although I don't see static/dist/ file path with any content so I am not sure why you added it, is it where the build happens? It doesn't seem to be committed

Yes, I added it just in case

@whilefoo whilefoo mentioned this pull request Feb 18, 2025
Open
@whilefoo whilefoo merged commit 04f8685 into ubiquity:development Feb 18, 2025
2 checks passed
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentlementlegen gentlementlegen gentlementlegen approved these changes

@rndquu rndquu rndquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cross repo diff checks for rewards
3 participants
@whilefoo @gentlementlegen @rndquu