chore: font cleanup - #1103
Closed
inffy wants to merge 8 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes bundled font packages from Aurora images and aligns default font settings with upstream Kinoite. The changes reduce image size by removing fonts available through Homebrew, while switching the fixed-width font default from FiraCode Nerd Font to Noto Sans Mono.
Key changes:
- Removed multiple font packages (FiraCode Nerd Font, JetBrains Mono, Inter, and several developer-oriented monospace fonts)
- Changed default fixed-width font from FiraCode Nerd Font to Noto Sans Mono in KDE settings
- Reorganized package inclusions/exclusions for Fedora 42 and 43
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| system_files/shared/usr/share/kde-settings/kde-profile/default/xdg/kdeglobals | Updates KDE default fixed-width font to Noto Sans Mono |
| packages.json | Removes font packages from both base and dx variants, reorganizes version-specific package lists |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
renner0e
reviewed
Oct 21, 2025
| "bcc", | ||
| "bpftop", | ||
| "bpftrace", | ||
| "cascadia-code-fonts", |
Member
There was a problem hiding this comment.
what about vscode? I don't use it but this feels wrong. We should probably change it to something else for new users at least.
https://github.com/ublue-os/aurora/blob/main/system_files/dx/etc/skel/.config/Code/User/settings.json
Member
Author
There was a problem hiding this comment.
aaargh
Umm well I don't know...Maybe put the default as DejaVu (although it should fallback anyway). Then we could add these fonts (most of them already are) in the fonts brewfile.
But we also need to add https://formulae.brew.sh/cask/font-symbols-only-nerd-font#default --> added this to the brew ai pr
Member
|
this is the output of rpm-ostree db diff |
renner0e
reviewed
Oct 21, 2025
renner0e
left a comment
renner0e
left a comment
Member
There was a problem hiding this comment.
I tested this by setting jetbrains mono in konsole and rebased to the image, konsole still has a font so I think we are good
Member
Author
|
I was just thinking, should we wait until F43? |
Member
sure let's wait for F43 on that one, put it in the forum post as well and point people to the brew stuff |
renner0e
marked this pull request as draft
October 21, 2025 19:24
Member
Author
|
Let's do this in #1142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed some of the fonts we are shippng, there was actually pretty many especially on the DX image.
I think these pretty much can be found from Brew.
Also changed the defaults so we are now aligned with Kinoite
fixes: #391