Skip to content

feat: disable legacy nvidia builds for beta images - #1121

Merged
renner0e merged 5 commits into
mainfrom
copilot/disable-legacy-nvidia-images
Oct 21, 2025
Merged

feat: disable legacy nvidia builds for beta images#1121
renner0e merged 5 commits into
mainfrom
copilot/disable-legacy-nvidia-images

Conversation

Copilot AI commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR disables legacy NVIDIA driver image builds for the beta stream while keeping the newer nvidia-open driver images available.

Changes

Modified .github/workflows/build-image-beta.yml to explicitly specify image_flavors parameter, excluding the legacy nvidia flavor:

image_flavors: '["main", "nvidia-open"]'

Impact

Before:

  • Beta builds used the default flavors: ['main', 'nvidia', 'nvidia-open']
  • Built 6 images total (2 base variants × 3 flavors)

After:

  • Beta builds now only use: ['main', 'nvidia-open']
  • Builds 4 images total (2 base variants × 2 flavors)
  • Legacy NVIDIA proprietary driver images are no longer built for beta
  • Modern nvidia-open driver images remain available for beta users

Other streams remain unchanged:

  • latest stream continues to build all three flavors
  • stable stream continues to use defaults (all three flavors)
  • hwe variants continue to include both nvidia driver options

Rationale

This change reduces build time and storage for beta images by removing the legacy NVIDIA driver variant while maintaining support for users with NVIDIA GPUs through the newer open-source driver option.

Testing

  • ✅ YAML syntax validated with pre-commit hooks
  • ✅ All formatting checks passed
  • ✅ Change follows existing pattern used in other workflows
Original prompt

Task: Disable legacy nvidia image building for the beta images. Leave the new nvidia-open images available


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits October 21, 2025 12:23
Co-authored-by: inffy <10782843+inffy@users.noreply.github.com>
Only build main and nvidia-open flavors for beta stream, excluding legacy nvidia driver support

Co-authored-by: inffy <10782843+inffy@users.noreply.github.com>
Copilot AI changed the title [WIP] Disable legacy nvidia image building for beta images feat: disable legacy nvidia builds for beta images Oct 21, 2025
Copilot AI requested a review from inffy October 21, 2025 12:26
@inffy
inffy marked this pull request as ready for review October 21, 2025 13:14
@inffy
inffy requested a review from NiHaiden as a code owner October 21, 2025 13:14
Copilot AI review requested due to automatic review settings October 21, 2025 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables legacy NVIDIA proprietary driver image builds for the beta stream while maintaining the newer nvidia-open driver variant, reducing build complexity and storage requirements for beta releases.

Key changes:

  • Modified beta workflow to explicitly exclude the legacy nvidia flavor
  • Reduced beta image build count from 6 to 4 images
  • Maintained nvidia-open driver support for beta users with NVIDIA hardware

Reviewed Changes

Copilot reviewed 5 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/build-image-beta.yml Added explicit image_flavors parameter to exclude legacy nvidia builds
system_files/shared/usr/share/kde-settings/kde-profile/default/xdg/kwinrc Removed trailing blank lines
system_files/shared/usr/share/glib-2.0/schemas/zz0-aurora-modifications.gschema.override Removed trailing blank line
system_files/shared/etc/skel/.config/starship.toml Removed trailing blank line
build_files/dx/10-tests-dx.sh Removed trailing blank line

@renner0e
renner0e enabled auto-merge October 21, 2025 20:19

@renner0e renner0e left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renner0e
renner0e added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 8231d2a Oct 21, 2025
28 checks passed
@renner0e
renner0e deleted the copilot/disable-legacy-nvidia-images branch October 21, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants