feat: add brewfile validation - #1132
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
inffy
marked this pull request as ready for review
October 22, 2025 07:50
inffy
enabled auto-merge
October 22, 2025 07:50
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Homebrew brewfile validation to the Aurora build system. The changes introduce a GitHub Actions workflow to validate brewfiles on pull requests and reorganize how brewfiles are handled during the container build process.
Key Changes:
- Adds automated brewfile validation via GitHub Actions
- Moves brewfile copying to the shared build stage for better organization
- Removes redundant tap declaration from aurora-ai.Brewfile
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/validate-brewfiles.yml |
New workflow to validate brewfiles using Homebrew bundle |
build_files/shared/build-base.sh |
Copies brewfiles to /usr/share/ublue-os/homebrew/ during build |
Containerfile |
Adds /brew directory to build context |
brew/aurora-ai.Brewfile |
Removes redundant homebrew/cask tap declaration |
renner0e
reviewed
Oct 22, 2025
Co-authored-by: renner <80410025+renner0e@users.noreply.github.com>
renner0e
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are picked from Bluefin:
ublue-os/bluefin#3450
ublue-os/bluefin#3449
We already had the brewfiles on the image but i feel it's easier to find now that they are in the root brew folder and then copied to the correct folder.