Skip to content

feat: add flatpak validation workflow #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renner0e merged 6 commits into from
Oct 23, 2025
Merged

feat: add flatpak validation workflow #1135

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad01152
feat: add flatpak validation workflow
inffy Oct 22, 2025
3401167
fix: naming
renner0e Oct 22, 2025
c0657d8
Merge branch 'main' into flatpak-validation
inffy Oct 22, 2025
79fe0b5
fix: use flathub api
renner0e Oct 23, 2025
20b3754
fix: make it exit on error
renner0e Oct 23, 2025
dd95374
Merge branch 'main' into flatpak-validation
renner0e Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/validate-flatpaks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Validate Flatpaks
permissions:
contents: read

on:
pull_request:
paths:
- "flatpaks/**"
jobs:
validate:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5

- name: Set up Flathub
shell: bash
run: |
sudo apt install -y flatpak
flatpak remote-add --user --if-not-exists flathub https://dl.flathub.org/repo/flathub.flatpakrepo

- name: Validate Flatpaks
shell: bash
run: |
echo "Validating flatpak files in flatpaks/ directory..."

set -xeuo pipefail

find "flatpaks" -iname '*\.list*' -print0 | \
while IFS= read -r -d '' flatpaks_file ; do \
echo "::group:: ===$(basename "$flatpaks_file")==="
grep -v "#.*" "$flatpaks_file" | \

Copilot AI Oct 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grep pattern '#.' will only filter lines that start with '#'. Lines with comments after content (e.g., 'app.id # comment') will not be properly filtered. Use 'sed 's/#.//' to remove inline comments or adjust the pattern to '^[[:space:]]*#' to only skip comment-only lines.

Suggested change
grep -v "#.*" "$flatpaks_file" | \
sed 's/#.*//' "$flatpaks_file" | grep -v '^[[:space:]]*$' | \

Copilot uses AI. Check for mistakes.
while read -r flatpak ; do \

Copilot AI Oct 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty lines from the grep output will cause 'flatpak remote-info' to fail with an invalid argument. Add a check to skip empty lines: 'while read -r flatpak ; do [[ -n "$flatpak" ]] || continue'.

Suggested change
while read -r flatpak ; do \
while read -r flatpak ; do \
[[ -n "$flatpak" ]] || continue \

Copilot uses AI. Check for mistakes.
flatpak remote-info --user flathub "${flatpak}"
done
echo "::endgroup::"
done