chore: refactor package installation and handling during build time - #1142
Conversation
This reverts commit 6c2c120.
|
Well it builds now. Now just have to figure out if we are missing something important |
we never added any of them did we? This is just bluefin legacy I guess? we don't even have those installed for whatever reason, on brew same for git-svn, it's on brew anyway the reason for adding git-svn was too much dependencies needed on brew |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the package installation process to use isolated COPR repository enablement, improving security by preventing malicious repositories from injecting fake versions of Fedora packages. The changes remove the global enabling of COPR repositories and introduce helper functions for secure, isolated package installation.
Key changes:
- Introduces isolated COPR installation pattern where repositories are enabled only for specific package installs
- Removes
packages.jsonconfiguration file in favor of explicit package lists in build scripts - Adds repository validation script to ensure all repos are disabled before image commit
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages.json | Removed entire JSON configuration file containing package lists |
| build_files/shared/copr-helpers.sh | New helper functions for isolated COPR and third-party repo installation |
| build_files/shared/validate-repos.sh | New validation script to ensure all repositories are disabled before commit |
| build_files/base/04-packages.sh | Refactored to use explicit package arrays and isolated COPR installation |
| build_files/dx/03-packages-dx.sh | Refactored DX packages to use isolated COPR installation pattern |
| build_files/base/02-install-copr-repos.sh | Removed file that globally enabled COPR repositories |
| build_files/dx/01-install-copr-repos-dx.sh | Removed file that globally enabled COPR repositories for DX |
| build_files/dx/02-install-kernel-akmods-dx.sh | Removed DX-specific kernel/akmod installation script |
| build_files/base/17-cleanup.sh | Updated cleanup to handle isolated repo pattern |
| build_files/dx/09-cleanup-dx.sh | Simplified cleanup for isolated repo pattern |
| build_files/shared/build-base.sh | Removed packages.json copy and COPR repos script call, added validation |
| build_files/shared/build-dx.sh | Removed packages.json copy and COPR/akmods script calls, added validation |
| build_files/base/05-override-install.sh | Moved Starship installation to use direct binary download |
| build_files/base/03-install-kernel-akmods.sh | Restructured conditional logic for beta/stable AKMOD installation |
| build_files/base/20-tests.sh | Removed starship from test packages list |
| build_files/dx/10-tests-dx.sh | Removed lxc from DX test packages and trailing newline |
| just/aurora-system.just | Removed configure-vfio recipe (104 lines) |
| Containerfile | Removed packages.json from COPY instructions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Think we are ready (finally) |
I think we are missing our dnf swap for fwupd
last blocker ublue-os/packages#978 |

Refactor the package installation and COPR stuff
Closes #1115