chore: more repo cleanup - #1180
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates Aurora's build process and aligns it with Bluefin's build infrastructure changes. It simplifies the container build by removing the multi-stage approach and streamlining package installations with isolated repo enablement.
Key changes:
- Merges multi-stage container build into single-stage with conditional DX build
- Consolidates package installations to use isolated repo enablement pattern
- Removes standalone repo configuration files in favor of inline repo setup during builds
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| system_files/shared/etc/yum.repos.d/tailscale.repo | Removed static Tailscale repo config; now installed via inline repo setup |
| system_files/dx/etc/yum.repos.d/vscode.repo | Removed static VSCode repo config; now installed via inline repo setup |
| system_files/dx/etc/yum.repos.d/docker-ce.repo | Removed static Docker repo config; now installed via inline repo setup |
| build_files/shared/clean-stage.sh | Enhanced cleanup to use dnf clean all, comprehensive /var and /boot cleanup, and added bootc container lint |
| build_files/shared/build.sh | Moved Just file consolidation, removed call to deleted base-image-changes.sh, integrated DX build conditionally |
| build_files/shared/build-dx.sh | Simplified to call consolidated dx/00-dx.sh, removed redundant cleanup and ostree commit |
| build_files/dx/09-cleanup-dx.sh | Deleted; systemd enablement and repo cleanup moved to dx/00-dx.sh |
| build_files/dx/04-override-install-dx.sh | Deleted; ls-iommu installation moved elsewhere or removed |
| build_files/dx/00-dx.sh | Consolidated all DX setup including package lists, Docker/VSCode inline repo installation, service enablement, and repo cleanup |
| build_files/base/18-workarounds.sh | Removed commented-out atheros-firmware workaround section |
| build_files/base/07-base-image-changes.sh | Deleted; all base image branding and configuration moved to 05-override-install.sh |
| build_files/base/05-override-install.sh | Consolidated base image changes including wallpaper setup, Ptyxis config, gschema compilation, and Samba configuration |
| build_files/base/04-packages.sh | Moved Tailscale to inline repo installation, updated OpenRazer installation to use isolated repo pattern, removed sunshine from exclusions |
| Justfile | Removed multi-stage target logic, added IMAGE_FLAVOR build arg for conditional DX build |
| Containerfile | Removed multi-stage build (dx stage), added IMAGE_FLAVOR arg, changed to tmpfs mounts, added /opt symlink setup |
inffy
enabled auto-merge
October 28, 2025 05:04
we do that in the containerfile at the end
renner0e
reviewed
Oct 29, 2025
renner0e
reviewed
Oct 29, 2025
renner0e
approved these changes
Oct 31, 2025
renner0e
left a comment
Member
There was a problem hiding this comment.
booted an i mage with this and nothing was missing. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with bluefin ublue-os/bluefin#3477
Not sure what is happening with the Beta builds, although tomorrow is the release so those won't be available for long anyway