Skip to content

fix: workaround for selinux mprotect on composefs - #2315

Merged
inffy merged 2 commits into
ublue-os:mainfrom
inffy:selinux-nvidia-fix
Jun 4, 2026
Merged

fix: workaround for selinux mprotect on composefs#2315
inffy merged 2 commits into
ublue-os:mainfrom
inffy:selinux-nvidia-fix

Conversation

@inffy

@inffy inffy commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings June 4, 2026 16:09
@inffy
inffy requested review from NiHaiden, ledif and renner0e as code owners June 4, 2026 16:09
@codacy-production

codacy-production Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copilot AI reviewed Jun 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enable an SELinux workaround for NVIDIA images by adding an additional COPR-provided package to the base package installation step.

Changes:

  • Add ublue-os-selinux-workarounds to the set of packages installed from the ublue-os/packages COPR in the base build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build_files/base/01-packages.sh
@inffy
inffy marked this pull request as draft June 4, 2026 16:23
renner0e
renner0e requested changes Jun 4, 2026
View reviewed changes

@renner0e renner0e left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be not an issue exclusive to Nvidia
ublue-os/akmods#537 (comment)

@inffy

inffy commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

This seems to be not an issue exclusive to Nvidia ublue-os/akmods#537 (comment)

sigh, of course i missed that comment then..ffs

@inffy
inffy force-pushed the selinux-nvidia-fix branch from 3279413 to ababb03 Compare June 4, 2026 16:50
@inffy inffy changed the title fix(nvidia): enable selinux workaround for nvidia fix: enable selinux workaround Jun 4, 2026
@inffy inffy changed the title fix: enable selinux workaround fix: workaround for selinux mprotect on composefs Jun 4, 2026
renner0e
renner0e reviewed Jun 4, 2026
View reviewed changes
Comment thread build_files/base/01-packages.sh
@inffy
inffy force-pushed the selinux-nvidia-fix branch from ababb03 to b145bd5 Compare June 4, 2026 17:03
@inffy
inffy marked this pull request as ready for review June 4, 2026 19:35
@inffy
inffy added this pull request to the merge queue Jun 4, 2026
Merged via the queue into ublue-os:main with commit 2c0782d Jun 4, 2026
13 checks passed
@inffy
inffy deleted the selinux-nvidia-fix branch June 4, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@renner0e renner0e renner0e approved these changes
@NiHaiden NiHaiden Awaiting requested review from NiHaiden NiHaiden is a code owner
@ledif ledif Awaiting requested review from ledif ledif is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inffy @renner0e