fix(ci): add commit hash as org.opencontainers.image.revision label - #2340
Merged
Conversation
Up to standards ✅🟢 Issues
|
renner0e
commented
Jun 7, 2026
| LABELS+=("--label" "org.opencontainers.image.vendor={{ repo_organization }}") | ||
| LABELS+=("--label" "org.opencontainers.image.version=${ver}") | ||
| if [[ -z "$(git status -s)" ]]; then | ||
| LABELS+=("--label" "org.opencontainers.image.revision=$(git rev-parse HEAD)") |
Member
Author
There was a problem hiding this comment.
not using rev-parse short because that's the way the hhd rechunker did things...
We can also use the short one, like everywhere else, I don't have a strong opinion about it
renner0e
force-pushed
the
fix-commits-changelogs
branch
from
June 7, 2026 15:18
8f49682 to
8873819
Compare
This label was previously created by the hhd/legacy-rechunker instead of on the image build process. We are now using the build-chunked-oci and in the near future chunkah which do not mess with the labels. Our changelogs script expects this label to be present in order for the commits since last release to show up. fixes: ublue-os#2338
renner0e
force-pushed
the
fix-commits-changelogs
branch
from
June 7, 2026 15:44
8873819 to
7d7627c
Compare
renner0e
marked this pull request as ready for review
June 7, 2026 15:55
inffy
approved these changes
Jun 7, 2026
|
Successfully created backport PR for |
renner0e
added a commit
that referenced
this pull request
Jun 7, 2026
…2340) (#2342) This label was previously created by the hhd/legacy-rechunker instead of on the image build process. We are now using the build-chunked-oci and in the near future chunkah which do not mess with the labels. Our changelogs script expects this label to be present in order for the commits since last release to show up. fixes: #2338 (cherry picked from commit a361fd3) Co-authored-by: renner <80410025+renner0e@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This label was previously created by the hhd/legacy-rechunker instead of on the image build process.
Our changelogs script expects this label to be present in order for the commits since last release to show up.
fixes: #2338