[Backport stable-f44] fix(release): tag selection in changelogs.py - #2375
Merged
Conversation
(cherry picked from commit 957f637)
aurora-backport
Bot
requested review from
inffy,
ledif and
renner0e
as code owners
June 12, 2026 07:13
renner0e
enabled auto-merge (squash)
June 12, 2026 07:14
renner0e
approved these changes
Jun 12, 2026
Not up to standards ⛔
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of PR #2363 to
stable-f44.Please review the changes.
Original PR Description:
This PR fixes an issue with choosing incorrect tags when we have multiple builds on the same day. We now group tags by date and make sure to only select the same date when there are multiple builds.
Tested:
$ python -m doctest .github/changelogs.py -v Trying: imgs = lambda tags: {"aurora": {"RepoTags": tags}} Expecting nothing ok Trying: get_tags("stable", imgs(["stable-20260602.1", "stable-20260609", "stable-20260609.1"])) Expecting: ('stable-20260602.1', 'stable-20260609.1') ok Trying: get_tags("stable", imgs(["stable-20260602.1", "stable-20260609.1", "stable-20260609.2"])) Expecting: ('stable-20260602.1', 'stable-20260609.2') ok Trying: get_tags("stable", imgs(["stable-20260526", "stable-20260602", "stable-20260602.1", "stable-20260609", "stable-20260609.1"])) Expecting: ('stable-20260602.1', 'stable-20260609.1') ok 14 items had no tests: changelogs changelogs.START_PATTERN changelogs.calculate_changes changelogs.generate_changelog changelogs.get_commits changelogs.get_image_digest changelogs.get_images changelogs.get_manifests changelogs.get_package_groups changelogs.get_packages changelogs.get_sbom changelogs.get_versions changelogs.main changelogs.parse_sbom_packages 1 item passed all tests: 4 tests in changelogs.get_tags 4 tests in 15 items. 4 passed. Test passed.Closes #2362.
Disclaimer: written with iteration from Sonnet 4.6. Test plan is mine.