[WIP] feat: add integration testing for images - #617
Closed
ledif wants to merge 15 commits into
Closed
Conversation
Member
Happy to help out if wanted! :D |
p5
reviewed
Jun 19, 2025
p5
left a comment
p5
left a comment
Member
There was a problem hiding this comment.
Ignored the obvious bits you've not yet got round to (like calling Python rather than Go in the workflow), but LGTM!
Comment on lines
+86
to
+94
| - name: Stop QEMU | ||
| env: | ||
| QEMU_PID: ${{ steps.run-qemu.outputs.QEMU_PID }} | ||
| run: | | ||
| echo "Stopping QEMU with PID $QEMU_PID" | ||
| kill $QEMU_PID | ||
| wait $QEMU_PID || true | ||
| sleep 5 | ||
| echo "QEMU stopped" |
Member
There was a problem hiding this comment.
This probably isn't necessary since the runners will be terminated by GitHub at the end of the run, but also doesn't harm anything.
Co-authored-by: Robert Sturla <robertsturla@outlook.com>
Member
|
Ooooo lets gooooo |
Member
Author
|
We might want to use https://github.com/secureblue/bootc-integration-test-action instead. |
Member
|
openqa has a container btw https://github.com/os-autoinst/openQA/blob/master/docs/Installing.asciidoc#container-based-setup |
Member
Author
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not functional at the moment. Based on rsturla-homelab/bootc-centos-base#45.