Skip to content

fix(bazaar): add NVIDIA workaround - #2747

Merged
castrojo merged 3 commits into
ublue-os:mainfrom
ledif:bazaar-nvidia
Jul 9, 2025
Merged

fix(bazaar): add NVIDIA workaround#2747
castrojo merged 3 commits into
ublue-os:mainfrom
ledif:bazaar-nvidia

Conversation

@ledif

@ledif ledif commented Jul 9, 2025

Copy link
Copy Markdown
Member

Pulling in ublue-os/bazzite#2859.

@ledif

ledif commented Jul 9, 2025

Copy link
Copy Markdown
Member Author

This seems to properly patch the .desktop file.

❯ podman run --rm localhost/bluefin-nvidia-open:latest cat /usr/share/applications/io.github.kolunmi.Bazaar.desktop
[Desktop Entry]
Name[cs]=Bazaar
Name[fr]=Bazaar
Name[ru]=Bazaar
Name=Bazaar
Comment=Add, remove or update flatpak software on this computer
Exec=env GSK_RENDERER=opengl bazaar window --auto-service
Icon=io.github.kolunmi.Bazaar
Terminal=false
Type=Application
Categories=Utility;
Keywords[cs]=GTK;Systém;SprávceBalíčků;Discover;Flatpak;Software;Store;
Keywords[fr]=GTK;Système;GestionnaireDePaquets;Discover;Flatpak;Logiciel;Store;
Keywords[ru]=GTK;Система;УправлениеПакетами;Discover;Flatpak;Приложения;Магазин;
Keywords=GTK;System;PackageManager;Discover;Flatpak;Software;Store;
StartupNotify=true

@ledif
ledif marked this pull request as ready for review July 9, 2025 00:50
Copilot AI review requested due to automatic review settings July 9, 2025 00:50
@dosubot dosubot Bot added size/XS This PR changes 0-9 lines, ignoring generated files. kind/bug Something isn't working labels Jul 9, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a workaround in the base build script to ensure the Bazaar desktop entry uses OpenGL rendering on NVIDIA systems.

  • Detects image-flavor set to nvidia via jq and grep
  • Applies a sed command to prepend GSK_RENDERER=opengl to the Bazaar Exec line
Comments suppressed due to low confidence (1)

build_files/base/18-workarounds.sh:30

  • Consider adding or updating automated tests for this script to verify that the NVIDIA workaround correctly updates the desktop entry when image-flavor is nvidia.
# Workaround for Bazaar on NVIDIA systems

Comment thread build_files/base/18-workarounds.sh Outdated
Comment thread build_files/base/18-workarounds.sh
@castrojo
castrojo enabled auto-merge July 9, 2025 01:25
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2025
@castrojo
castrojo added this pull request to the merge queue Jul 9, 2025
Merged via the queue into ublue-os:main with commit 56c3cd7 Jul 9, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working lgtm This PR has been approved by a maintainer size/XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants