Skip to content

chore: add workflow image version options to ISO build - #2958

Merged
castrojo merged 1 commit into
mainfrom
hanthor-patch-1
Aug 8, 2025
Merged

chore: add workflow image version options to ISO build#2958
castrojo merged 1 commit into
mainfrom
hanthor-patch-1

Conversation

@hanthor

@hanthor hanthor commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

want an option to build only LTS

Copilot AI review requested due to automatic review settings August 8, 2025 13:11
@dosubot dosubot Bot added size/S This PR changes 10-29 lines, ignoring generated files. github_actions labels Aug 8, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds workflow input options to control which image versions are built during the ISO build process. It introduces a choice parameter that allows users to select between building LTS, GTS, stable, or all image versions instead of always building everything.

Key Changes

  • Added workflow_dispatch input parameter for selective image version building
  • Provided four image version options: lts, gts, stable, and all

description: 'Which image version to build'
type: choice
required: true
default: 'all'

Copilot AI Aug 8, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input parameter is added but there's no corresponding logic in the workflow to actually use this image_version input. The parameter will be ignored unless the workflow steps are updated to reference ${{ inputs.image_version }} to conditionally build only the selected image versions.

Copilot uses AI. Check for mistakes.
@castrojo
castrojo enabled auto-merge August 8, 2025 13:14
@hanthor
hanthor marked this pull request as draft August 8, 2025 13:14
auto-merge was automatically disabled August 8, 2025 13:14

Pull request was converted to draft

@castrojo
castrojo marked this pull request as ready for review August 8, 2025 13:14
@castrojo
castrojo merged commit 092e682 into main Aug 8, 2025
11 of 13 checks passed
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2025
@castrojo
castrojo deleted the hanthor-patch-1 branch August 8, 2025 13:14
@dosubot dosubot Bot added the area/iso Making installable images label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iso Making installable images lgtm This PR has been approved by a maintainer size/S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants