feat: add optional cloudflare upload to Anaconda Live ISO workflow - #2959
Merged
Conversation
hanthor
requested review from
castrojo,
m2Giles,
p5 and
tulilirockz
as code owners
August 8, 2025 13:17
dosubot
Bot
added
size/S
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional control over artifact uploads in the Anaconda Live ISO workflow, allowing users to selectively enable/disable uploads to job artifacts and Cloudflare R2 storage when manually triggering the workflow.
- Changed default image version from 'all' to 'lts' for workflow dispatch
- Added boolean inputs for controlling artifact and R2 uploads with sensible defaults
- Updated matrix logic to support dynamic image version selection based on workflow trigger
Comments suppressed due to low confidence (1)
.github/workflows/reusable-build-iso-anaconda.yml:47
- This complex inline expression is difficult to read and maintain. Consider extracting this logic into a separate job step that outputs the appropriate matrix values, or break it into multiple conditions for better readability.
image_version: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.image_version == 'all' && fromJSON('["gts", "stable", "lts"]') || fromJSON(format('["{0}"]', github.event.inputs.image_version))) || fromJSON('["gts", "stable"]') }}
|
|
||
| - name: Upload to CloudFlare | ||
| if: github.event_name != 'pull_request' | ||
| if: github.event_name != 'pull_request' && (github.event_name != 'workflow_dispatch' || github.event.inputs.upload_r2) |
There was a problem hiding this comment.
The condition logic could be simplified. When github.event_name is 'workflow_dispatch', the first part of the AND condition is always true, making it redundant. Consider simplifying to: github.event_name != 'pull_request' && (github.event_name != 'workflow_dispatch' || github.event.inputs.upload_r2 == 'true')
castrojo
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so we don't have to upload to CF each time