Skip to content

feat: add renovate rules for GNOME extension submodules #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
castrojo wants to merge 1 commit into from
Closed

feat: add renovate rules for GNOME extension submodules #3570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
},
],

// Enable git-submodules manager for GNOME extensions
"git-submodules": {
"enabled": true
},

"packageRules": [
{
"automerge": true,
Expand All @@ -38,6 +43,41 @@
"automerge": true,
"matchUpdateTypes": ["digest"],
"matchDepNames": ["ghcr.io/ublue-os/silverblue-main"],
},
// GNOME extensions git-submodules - track stable releases where available
{
"matchManagers": ["git-submodules"],
"matchPackagePatterns": ["ubuntu/gnome-shell-extension-appindicator"],
"versioning": "semver",
"automerge": false
},
Comment on lines +47 to +53

@p5 p5 Nov 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules shouldn't be needed. Renovate will use semver already

{
"matchManagers": ["git-submodules"],
"matchPackagePatterns": ["micheleg/dash-to-dock"],
"versioning": "regex:^extensions\\.gnome\\.org-v(?<major>\\d+)$",

Copilot AI Nov 2, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The regex pattern only captures major version numbers. If dash-to-dock uses versions like 'extensions.gnome.org-v85' this will work, but consider if minor/patch versions might be needed in the future. Verify that this extension's tagging strategy truly only uses major versions.

Suggested change
"versioning": "regex:^extensions\\.gnome\\.org-v(?<major>\\d+)$",
"versioning": "regex:^extensions\\.gnome\\.org-v(?<version>\\d+(?:\\.\\d+){0,2})$",

Copilot uses AI. Check for mistakes.
"automerge": false
},
{
"matchManagers": ["git-submodules"],
"matchPackagePatterns": ["GSConnect/gnome-shell-extension-gsconnect"],
"versioning": "semver",
"automerge": false
},
{
"matchManagers": ["git-submodules"],
"matchPackagePatterns": ["eonpatapon/gnome-shell-extension-caffeine"],
"versioning": "semver",
"automerge": false
},
Comment on lines +47 to +71

Copilot AI Nov 2, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Each git-submodule rule repeats 'matchManagers' and 'automerge' fields. Consider consolidating rules with the same versioning strategy to reduce duplication. For example, the three semver extensions (lines 48-53, 60-65, 66-71) could be combined into a single rule with multiple matchPackagePatterns.

Copilot uses AI. Check for mistakes.

@castrojo castrojo Nov 2, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

// GNOME extensions without releases - track main/master branch
{
"matchManagers": ["git-submodules"],
"matchPackagePatterns": [
"xscriptor/blur-my-shell",
"ublue-os/Logomenu",
"icedman/search-light"
],
"automerge": false
}
]
}
Loading