Skip to content

fix: correct schedule event check in generate-release workflow #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

fix: correct schedule event check in generate-release workflow #3608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f498cf
Initial plan
Copilot Nov 6, 2025
b604a03
fix: correct schedule check in generate-release workflow
Copilot Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generate-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

- name: Create Release
uses: softprops/action-gh-release@6da8fa9354ddfdc4aeace5fc48d7f679b5214090 # v2
if: contains(fromJson('["gts", "stable"]'), matrix.version) && (github.event.schedule == '0 1 * * TUE' || contains(fromJson('["workflow_dispatch", "workflow_call"]'), github.event_name))
if: contains(fromJson('["gts", "stable"]'), matrix.version) && contains(fromJson('["schedule", "workflow_dispatch", "workflow_call"]'), github.event_name)

Copilot AI Nov 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow does not have a schedule trigger defined in its on: section (only workflow_call and workflow_dispatch). When this workflow is called via workflow_call from parent workflows that have schedule triggers (like build-image-gts.yml and build-image-stable.yml), github.event_name will be workflow_call, not schedule. The schedule event context is not propagated to called workflows. This condition will never match schedule events, making the change ineffective. Consider either: (1) keeping the original condition that worked by checking the specific schedule, or (2) adding a workflow input parameter to pass schedule context from parent workflows.

Suggested change
if: contains(fromJson('["gts", "stable"]'), matrix.version) && contains(fromJson('["schedule", "workflow_dispatch", "workflow_call"]'), github.event_name)
if: contains(fromJson('["gts", "stable"]'), matrix.version) && contains(fromJson('["workflow_dispatch", "workflow_call"]'), github.event_name)

Copilot uses AI. Check for mistakes.
with:
name: ${{ steps.generate-release-text.outputs.title }}
tag_name: ${{ steps.generate-release-text.outputs.tag }}
Expand Down
Loading