Skip to content

feat: deprecate GTS image tag and migrate to stable - #4251

Merged
castrojo merged 7 commits into
ublue-os:mainfrom
ahmedadan:deprecate-gts-image-tag
Mar 12, 2026
Merged

feat: deprecate GTS image tag and migrate to stable#4251
castrojo merged 7 commits into
ublue-os:mainfrom
ahmedadan:deprecate-gts-image-tag

Conversation

@ahmedadan

@ahmedadan ahmedadan commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

This removes the dedicated GTS build pipeline and instead adds gts as a tag alias produced by the stable build, done in two parts within the same PR:

  1. Repoints gtsstable: On weekly Tuesday builds and workflow_dispatch, the stable build now produces versioned gts tags (gts-${version}, gts-${version:3}) alongside the existing stable tags.
  2. Removes GTS CI: Deletes the dedicated build workflow, strips gts from the Justfile, release generation, and all docs/comments.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. area/just Justfile things kind/github-action Anything having to do with GHA and automation labels Mar 1, 2026
@ahmedadan
ahmedadan force-pushed the deprecate-gts-image-tag branch from e8f74f3 to e3dbaea Compare March 1, 2026 20:21
@castrojo

castrojo commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

End of an era! <3

@castrojo

castrojo commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

In my review the agent noticed a missing gts floating tag for the undated versions and is recommending this:

In Justfile, all three production stable branches need "gts" added:

  •    BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}" "gts-${version}" "gts-${version:3}")
    
  •    BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}" "gts" "gts-${version}" "gts-${version:3}")
    

That's three identical lines (schedule, workflow_dispatch/call, local build) — same single token added to each. No other files need changing.

@castrojo

castrojo commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Ok I'm heading on a trip for the next week so if we're good with this then let's get it ready to deploy? Is there a way to test this ahead of time?

@renner0e

renner0e commented Mar 3, 2026

Copy link
Copy Markdown
Member

Ok I'm heading on a trip for the next week so if we're good with this then let's get it ready to deploy? Is there a way to test this ahead of time?

Testing it in a fork and seeing if it actually pushes the same GTS tags on the stable workflows?

@castrojo

castrojo commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Tested in a branch ... here's the run logs for each image, manual review strongly preferred. 😄

@hanthor

hanthor commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Ok I'm heading on a trip for the next week so if we're good with this then let's get it ready to deploy? Is there a way to test this ahead of time?

Testing it in a fork and seeing if it actually pushes the same GTS tags on the stable workflows?

@ahmedadan I'm not seeing the part where gts is getting pointed to stable can you point it out?

Comment thread Justfile
Comment on lines -630 to +633
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}")
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}" "gts" "gts-${version}" "gts-${version:3}")
elif [[ "{{ tag }}" =~ "stable" && "${github_event}" =~ workflow_dispatch|workflow_call ]]; then
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}")
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}" "gts" "gts-${version}" "gts-${version:3}")
elif [[ "{{ tag }}" =~ "stable" && "{{ ghcr }}" == "0" ]]; then
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}")
BUILD_TAGS+=("stable" "stable-${version}" "stable-${version:3}" "gts" "gts-${version}" "gts-${version:3}")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specifically it's in the generate tag and tags images and step in reusable-build.yml, https://github.com/castrojo/bluefin/actions/runs/22684304133/job/65762980566#step:15:23

castrojo
castrojo previously approved these changes Mar 7, 2026
@ahmedadan
ahmedadan added this pull request to the merge queue Mar 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 7, 2026
@ahmedadan
ahmedadan added this pull request to the merge queue Mar 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 7, 2026
@ahmedadan
ahmedadan force-pushed the deprecate-gts-image-tag branch from 532c3a0 to 955f779 Compare March 7, 2026 16:40
m2Giles
m2Giles previously approved these changes Mar 11, 2026
@castrojo
castrojo added this pull request to the merge queue Mar 11, 2026
@castrojo

Copy link
Copy Markdown
Collaborator

@bsherman @bketelsen @KyleGospo @tulilirockz @hanthor @ahmedadan @daegalus @marcoceppi @p5 and everyone else who helped shape Bluefin. Please feel free to leave some words for our now extinct Bluefin GTS.

Someday I will make a GNOME -1 branch in Dakotaraptor out of sheer hatred for extension jank.

Goodbye Bluefin GTS, you were the first of her kind, the holotype.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Mar 12, 2026
@castrojo
castrojo merged commit 49d0f11 into ublue-os:main Mar 12, 2026
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/just Justfile things kind/github-action Anything having to do with GHA and automation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants