fix(gnome): use gsettings override for blur-my-shell - #4819
Conversation
Use a system-wide GSettings override for blur-my-shell instead of the per-user setup hook. Assisted-by: MAI-Code-1-Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
This PR aims to make the Blur My Shell popup blur default a system-wide setting by switching from a per-user dconf write in the theming user-setup hook to a GSettings schema override under /usr/share/glib-2.0/schemas.
Changes:
- Removed the per-user
dconf writethat disabled Blur My Shell popup blur in10-theming.sh. - Added a new
*.gschema.overridefile to setorg.gnome.shell.extensions.blur-my-shell.popup:blur=falseby default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| system_files/shared/usr/share/ublue-os/user-setup.hooks.d/10-theming.sh | Removes per-user dconf modification for Blur My Shell popup blur. |
| system_files/shared/usr/share/glib-2.0/schemas/zz1-bluefin-extensions.gschema.override | Adds a global GSettings override intended to disable Blur My Shell popup blur by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [org.gnome.shell.extensions.blur-my-shell.popup] | ||
| blur=false |
|
For reviewers, the projectbluefin/common repo has moved on so we need to patch it here before migration. |
Summary
Testing
bash -n system_files/shared/usr/share/ublue-os/user-setup.hooks.d/10-theming.sh