Skip to content

feat(lts): improve LTS rebase-helper script - #776

Merged
castrojo merged 1 commit into
ublue-os:mainfrom
cloudwithdan:feat-416-improve-lts-rebase-helper
Aug 4, 2025
Merged

feat(lts): improve LTS rebase-helper script#776
castrojo merged 1 commit into
ublue-os:mainfrom
cloudwithdan:feat-416-improve-lts-rebase-helper

Conversation

@cloudwithdan

Copy link
Copy Markdown
Contributor

No description provided.

@cloudwithdan
cloudwithdan requested a review from Zeglius as a code owner August 2, 2025 16:32
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. ublue-cli bluefin-cli, aurora-cli, and bazzite-cli labels Aug 2, 2025
@cloudwithdan
cloudwithdan force-pushed the feat-416-improve-lts-rebase-helper branch from 1d962ea to 2a17d47 Compare August 2, 2025 16:40
@inffy

inffy commented Aug 3, 2025

Copy link
Copy Markdown
Member

Wouldn't this break the helper for every other image than bluefin-lts?

@cloudwithdan cloudwithdan changed the title Improve LTS rebase-helper script Improve Bluefin rebase-helper script Aug 3, 2025
@cloudwithdan cloudwithdan changed the title Improve Bluefin rebase-helper script Improve LTS rebase-helper script Aug 3, 2025
@cloudwithdan

Copy link
Copy Markdown
Contributor Author

Wouldn't this break the helper for every other image than bluefin-lts?

It shouldn't this is helper for LTS only as I understood, other images use this helper
ublue-os/bluefin#2914

@inffy

inffy commented Aug 3, 2025

Copy link
Copy Markdown
Member

Wouldn't this break the helper for every other image than bluefin-lts?

It shouldn't this is helper for LTS only as I understood, other images use this helper ublue-os/bluefin#2914

Yup you are right, forgot that we never moved them to here.

Move along, nothing to see here 😅

@hanthor

hanthor commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator

Eventually we just put the LTS behaviour in a case and merge the two

@castrojo
castrojo enabled auto-merge August 3, 2025 13:03
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 3, 2025
@cloudwithdan cloudwithdan changed the title Improve LTS rebase-helper script feat(lts): improve LTS rebase-helper script Aug 3, 2025
@castrojo
castrojo disabled auto-merge August 4, 2025 17:28
@castrojo
castrojo merged commit e524fa2 into ublue-os:main Aug 4, 2025
10 checks passed
@cloudwithdan
cloudwithdan deleted the feat-416-improve-lts-rebase-helper branch August 5, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. ublue-cli bluefin-cli, aurora-cli, and bazzite-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants