-
Notifications
You must be signed in to change notification settings - Fork 14
Add CI integration for e2e tests #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
These rely on YARF to test the authentication process of authd and its brokers, along with checking if the user was properly setup in the system.
This is a simple documentation that defines the requirements needed to run the tests locally. After the tests are automated and are stabilized, we should definitely focus on improving it.
Since YARF currently does not manage the VMs on its own, we need to manually provision and execute the VM in order to run the tests. There are also some other limitations (i.e. not being able to run tests from a specific robot file) that are covered by this script.
After some updates, the syntax for some of YARF's keywords changed alongside some fixes to a couple of issues with typing strings. This allows us to remove the Shift_L workaround and have a more streamlined code and a better reading experience.
Create a symlink e2e-tests/resources/broker which points to the broker implementation that's used by the tests and is updated by run_tests.sh. It's not perfect because code navigation will always navigate to the broker implementation which was last used in tests, but it's way better than no code navigation at all.
This workflow downloads an Ubuntu image, sets up some of the aplications and configurations that we will need in the VM in order to be able to run the E2E tests and then caches it for later use to save us some time when running the tests.
This workflow finishes provisioning the VM and then run the e2e tests for the authd-msentraid broker specifically.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 78.33% 78.33%
=======================================
Files 22 22
Lines 1274 1274
=======================================
Hits 998 998
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: Provision VM | ||
| id: provision-vm | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to use e2e-tests/vm/provision.py for this. if not we should update the script to make it work here. that way we also test the provisioning script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, definitely. After we get the other branch done, I'll update the commands here
720e21d to
a83a691
Compare
a83a691 to
33e7c5f
Compare
This PR adds workflows to provision and cache an Ubuntu VM and run the E2E tests for the authd-msentraid broker.
This is based on #659.
UDENG-7426