Use Go backports PPA in CI and bump go toolchain to 1.25.0 #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
reviewed
Sep 15, 2025
adombeck
force-pushed
the
go-1.25
branch
2 times, most recently
from
2ac8111 to
5dfc53a
Compare
3v1n0
reviewed
Sep 15, 2025
3v1n0
reviewed
Sep 15, 2025
3v1n0
reviewed
Sep 15, 2025
adombeck
commented
Sep 15, 2025
3v1n0
reviewed
Sep 15, 2025
3v1n0
reviewed
Sep 15, 2025
adombeck
force-pushed
the
go-1.25
branch
3 times, most recently
from
4bf732f to
e1255f2
Compare
3v1n0
reviewed
Sep 15, 2025
adombeck
force-pushed
the
go-1.25
branch
6 times, most recently
from
85ae717 to
0a85010
Compare
adombeck
changed the title
adombeck
force-pushed
the
go-1.25
branch
2 times, most recently
from
96147fc to
25c8557
Compare
Some of our dependencies now require a newer Go version than 1.23. Go 1.25 also allows us to use the new Output method of testing.T, making our test output easier to read.
With Go 1.25, `go test -race` failed with:
fatal error: checkptr: misaligned pointer conversion
goroutine 72 gp=0xc0002281c0 m=8 mp=0xc00018a008 [running]:
runtime.throw({0x16ece45?, 0x0?})
/home/user/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:1094 +0x48 fp=0xc0002f7150 sp=0xc0002f7120 pc=0x489cc8
runtime.checkptrAlignment(0xc0005fec1e, 0x1586820, 0x1)
/home/user/go/pkg/mod/golang.org/[email protected]/src/runtime/checkptr.go:20 +0x9a fp=0xc0002f7170 sp=0xc0002f7150 pc=0x41b8da
github.com/ubuntu/authd/internal/users/localentries.strvToSlice(0xc0005fec1e)
adombeck
force-pushed
the
go-1.25
branch
2 times, most recently
from
cd86626 to
214f0e2
Compare
3v1n0
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our dependencies now require a newer Go version than 1.23.
Go 1.25 also allows us to use the new Output method of testing.T, making our test output easier to read.
The Noble archives only have Go 1.23, so we use our own Go PPA to install Go 1.25.
UDENG-8125