Skip to content

Conversation

@adombeck
Copy link
Contributor

@adombeck adombeck commented Jun 16, 2025

authd (0.5.5) UNRELEASED; urgency=medium

  * Fix race with accounts service which could result in authd users not being
    listed in the GDM login screen.
  * When authenticating on the command-line, show a message that explains that
    the escape key can be used to go back.
  * Improve log message.
  * Update Go dependencies:
    - toolchain go1.23.10

 --  <[email protected]>  Mon, 16 Jun 2025 13:44:02 +0200

@adombeck adombeck requested a review from 3v1n0 June 16, 2025 12:00
Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, better to release early these fixes

@adombeck adombeck marked this pull request as ready for review June 17, 2025 18:32
@adombeck adombeck requested a review from a team as a code owner June 17, 2025 18:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (3261404) to head (408b0b4).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   85.71%   85.64%   -0.08%     
==========================================
  Files          82       82              
  Lines        5768     5794      +26     
  Branches      109      111       +2     
==========================================
+ Hits         4944     4962      +18     
- Misses        769      776       +7     
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3v1n0
Copy link
Collaborator

3v1n0 commented Jun 18, 2025

We want wait #987 here?

@adombeck
Copy link
Contributor Author

I found out that the workflow started for pushing the tag does not merge main, so I'm using the artifacts built from that

@3v1n0
Copy link
Collaborator

3v1n0 commented Jun 18, 2025

Even better!

authd (0.5.6) UNRELEASED; urgency=medium
authd (0.5.6) questing; urgency=medium

* New launchpad upload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, this was needed for?

I would like that we get a way to avoid to do uploads of invalid tags or ubuntu uploads though, maybe using your local fork and more ~pre uploads?

Maybe specify it better in changelog.

However... Please also use -v0.5.4 when generating the *.changes file to upload to the stable PPA :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did v0.5.5~pre1 for the testing. when I finalized the release, I removed that suffix and uploaded to launchpad to build the 0.5.5 release, and only when that was uploaded to the edge PPA I noticed in the diff that it contains unexpected changes from main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However... Please also use -v0.5.4 when generating the *.changes file to upload to the stable PPA :)

ah, too late, 0.5.6 is already building on launchpad with -v0.5.5 :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have two options, add another 0.5.7 entry or release with the .changes files with the diff between 0.5.6 and 0.5.5 (where the latter contains the changes from main)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal. But next time remember in order to ensure that the changes we generate is meaningful, so ignoring the minor updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure, makes sense, I just didn't think about it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I actually see that's still in edge only, no?

So if that is the case, you can just regenerate the changes file from that same source when uploading to stable no?
There's no need to do it through the lp UI (and sources are still the same, so no risk)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do that now

@adombeck adombeck merged commit 8264224 into main Jun 23, 2025
31 of 35 checks passed
@adombeck adombeck deleted the release-0.5.5 branch June 23, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants