DMB add package set handling to official content#364
DMB add package set handling to official content#364cpaelzer wants to merge 24 commits intoubuntu:mainfrom
Conversation
cpaelzer
requested review from
athos-ribeiro,
julian-klode,
lvoytek,
rkratky,
s-makin and
utkarsh2102
as code owners
|
I've worked through the links, references, spelling checks and a bit more on the phrasing. Should now be ready for review - marking as such... |
cpaelzer
force-pushed
the
dmb-add-package-set-handling
branch
2 times, most recently
from
b924467 to
1899462
Compare
|
Fixed the broken redirection (thanks Sally), improved a bad paragraph that I found and added a flowchart to explain the basic data relation visually. Rebased and re-pushed |
|
@basak I was hoping you'd have a chance for this (plus my potential follow up) before our DMB meeting on Monday 19th, so that afterwards I could update and act on the package list for server accordingly. I hope that just means you are busy and not totally opposed on how I tried to describe the split for logical/seeded lists :-) |
basak
left a comment
basak
left a comment
There was a problem hiding this comment.
I'm sorry, I thought I'd already submitted this review :-/
cpaelzer
force-pushed
the
dmb-add-package-set-handling
branch
from
8b21d36 to
380d0a3
Compare
|
We had two pre-reviews (thanks!) and I handled all feedback that came up. I'll mark it as non-draft to reflect that and will try to insert it into the Agenda for discussion, landing and then unblocking any dependent acting. |
cpaelzer
changed the title
|
@s-makin I've added your findings, could you please re-check if anything else is left - that way we might have your pre-ack so we can merge it if we agree at the DMB meeting as-is or with non-huge changes. |
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Co-authored-by: Benjamin Drung <bdrung@ubuntu.com>
Suggested-by: Benjamin Drung <bdrung@ubuntu.com> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Co-authored-by: Robie Basak <robie.basak@ubuntu.com> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
This reworks the former change, the intention was to make it consistent and review has shown that the single word form is preferred. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
cpaelzer
force-pushed
the
dmb-add-package-set-handling
branch
from
2980936 to
4f665fa
Compare
|
Rebased to latest main and resolved the remaining open discussion. |
This matches the conclusion out of discussions within the DMB. Seed based sets keep the goal of eventual consistensy with the seeds. All the indentified special cases become acknowledged reasons why it was hard to keep the automation active. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
cpaelzer
force-pushed
the
dmb-add-package-set-handling
branch
from
4f665fa to
ecac56d
Compare
5 participants
Description
While discussing the changes to the server package set we realized we'd like to document that there are two types, logical (defined by description) and seed based package sets. In the long past seed based lists were generated, but that had issues, but-rot and also sometimes one wanted to add/remove some. Therefore for now this described how non-generated lists can be maintained better by describing how the DMB wants to treat them.
While getting to that I found that we didn't yet leverage the related content out of the staging area, it was still as it was in the wiki without any rewrite.
The following is picking, placing and overhauling what I think would be useful to have.
And then adding the explanation and examples how seed based sets could be checked